linux-kernel - Re: [PATCH] NIOS2: setup.c: drop unused variable 'dram

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YVAFRdc/DWN0scc7@linux.ibm.com>
Date:   Sun, 26 Sep 2021 08:29:41 +0300
From:   Mike Rapoport <rppt@...ux.ibm.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>,
        Dinh Nguyen <dinguyen@...nel.org>,
        Andreas Oetken <andreas.oetken@...mens.com>,
        Mike Rapoport <rppt@...ux.vnet.ibm.com>
Subject: Re: [PATCH] NIOS2: setup.c: drop unused variable 'dram_start'

On Fri, Sep 24, 2021 at 02:05:25PM -0700, Randy Dunlap wrote:
> This is a nuisance when CONFIG_WERROR is set, so drop the variable
> declaration since the code that used it was removed.
> 
> ../arch/nios2/kernel/setup.c: In function 'setup_arch':
> ../arch/nios2/kernel/setup.c:152:13: warning: unused variable 'dram_start' [-Wunused-variable]
>   152 |         int dram_start;
> 
> Fixes: 7f7bc20bc41a ("nios2: Don't use _end for calculating min_low_pfn")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: kernel test robot <lkp@...el.com>
> Cc: Dinh Nguyen <dinguyen@...nel.org>
> Cc: Andreas Oetken <andreas.oetken@...mens.com>
> Cc: Mike Rapoport <rppt@...ux.vnet.ibm.com>

Reviewed-by: Mike Rapoport <rppt@...ux.ibm.com>

> ---
>  arch/nios2/kernel/setup.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> --- linux-next-20210917.orig/arch/nios2/kernel/setup.c
> +++ linux-next-20210917/arch/nios2/kernel/setup.c
> @@ -149,8 +149,6 @@ static void __init find_limits(unsigned
> 
>  void __init setup_arch(char **cmdline_p)
>  {
> -	int dram_start;
> -
>  	console_verbose();
> 
>  	memory_start = memblock_start_of_DRAM();

-- 
Sincerely yours,
Mike.