linux-kernel - Re: [PATCH] mm/damon/core: nullify pointer ctx->kdamond with a NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20210926054539.11630-1-sj@kernel.org>
Date:   Sun, 26 Sep 2021 05:45:39 +0000
From:   SeongJae Park <sj@...nel.org>
To:     Colin King <colin.king@...onical.com>
Cc:     SeongJae Park <sj@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/damon/core: nullify pointer ctx->kdamond with a NULL

Hello Colin, thank you for the patch!

> From: Colin Ian King <colin.king@...onical.com>
> 
> Currently a plain integer is being used to nullify the
> pointer ctx->kdamond. Use NULL instead. Cleans up sparse
> warning:
> 
> mm/damon/core.c:317:40: warning: Using plain integer as NULL pointer
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: SeongJae Park <sj@...nel.org>

Thanks,
SJ

> ---
>  mm/damon/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/damon/core.c b/mm/damon/core.c
> index 874558a790a0..c8665c80577a 100644
> --- a/mm/damon/core.c
> +++ b/mm/damon/core.c
> @@ -314,7 +314,7 @@ static int __damon_start(struct damon_ctx *ctx)
>  				nr_running_ctxs);
>  		if (IS_ERR(ctx->kdamond)) {
>  			err = PTR_ERR(ctx->kdamond);
> -			ctx->kdamond = 0;
> +			ctx->kdamond = NULL;
>  		}
>  	}
>  	mutex_unlock(&ctx->kdamond_lock);
> -- 
> 2.32.0