linux-kernel - Re: [PATCH 6/9] iio: adc: meson_saradc: Make use of the helper function dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFBinCAatVy_9abUJ7A6frbsOqDqAzVe9oDJODOS5MC7aCcDVg@mail.gmail.com>
Date:   Mon, 27 Sep 2021 22:09:47 +0200
From:   Martin Blumenstingl <martin.blumenstingl@...glemail.com>
To:     Cai Huoqing <caihuoqing@...du.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Neil Armstrong <narmstrong@...libre.com>,
        Kevin Hilman <khilman@...libre.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        linux-arm-kernel@...ts.infradead.org, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-amlogic@...ts.infradead.org
Subject: Re: [PATCH 6/9] iio: adc: meson_saradc: Make use of the helper
 function dev_err_probe()

Hello,

first of all: thanks for this patch!

On Mon, Sep 27, 2021 at 10:15 AM Cai Huoqing <caihuoqing@...du.com> wrote:
[...]
> +       if (IS_ERR(priv->clkin))
> +               return dev_err_probe(&pdev->dev,
> +                                    PTR_ERR(priv->clkin),
Is there any specific reason why you put PTR_ERR() on a separate line?
it would still fit into the line above and be below the old 80 chars
per line limit.
For priv->vref you already have it the way I am suggesting there.

[...]
> +       if (IS_ERR(priv->core_clk))
> +               return dev_err_probe(&pdev->dev,
> +                                    PTR_ERR(priv->core_clk),
the same question as above applies here as well


Best regards,
Martin