linux-kernel - Re: [PATCH] printk: avoid -Wsometimes-uninitialized warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210927175822.6c928128@oasis.local.home>
Date:   Mon, 27 Sep 2021 17:58:22 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Chris Down <chris@...isdown.name>, Petr Mladek <pmladek@...e.com>,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Jessica Yu <jeyu@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        John Ogness <john.ogness@...utronix.de>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        YueHaibing <yuehaibing@...wei.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        llvm@...ts.linux.dev
Subject: Re: [PATCH] printk: avoid -Wsometimes-uninitialized warning

On Mon, 27 Sep 2021 20:32:12 +0200
Arnd Bergmann <arnd@...nel.org> wrote:

> On Mon, Sep 27, 2021 at 6:21 PM Steven Rostedt <rostedt@...dmis.org> wrote:
> >
> > On Mon, 27 Sep 2021 14:19:18 +0100
> > Chris Down <chris@...isdown.name> wrote:
> >  
> > > Having IS_ENABLED and then an #ifdef seems to hurt code readability to me.  
> >
> > I agree.
> >
> > Would this be a better solution?  
> 
> Sounds good, I'll follow up with that version after the next round of randconfig
> builds.

OK, but can you remove the extra line that's between the brace and the
text. I should have deleted it in that patch.

-- Steve