lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 27 Sep 2021 11:55:57 +0200 From: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com> To: Arnd Bergmann <arnd@...nel.org>, "Rafael J. Wysocki" <rafael@...nel.org>, Viresh Kumar <viresh.kumar@...aro.org> Cc: Arnd Bergmann <arnd@...db.de>, linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org, linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] cpufreq: s3c244x: add fallthrough comments for switch On 27/09/2021 11:51, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@...db.de> > > Apparently nobody has so far caught this warning, I hit it in randconfig > build testing: > > drivers/cpufreq/s3c2440-cpufreq.c: In function 's3c2440_cpufreq_setdivs': > drivers/cpufreq/s3c2440-cpufreq.c:175:10: error: this statement may fall through [-Werror=implicit-fallthrough=] > camdiv |= S3C2440_CAMDIVN_HCLK3_HALF; > ^ > drivers/cpufreq/s3c2440-cpufreq.c:176:2: note: here > case 3: > ^~~~ > drivers/cpufreq/s3c2440-cpufreq.c:181:10: error: this statement may fall through [-Werror=implicit-fallthrough=] > camdiv |= S3C2440_CAMDIVN_HCLK4_HALF; > ^ > drivers/cpufreq/s3c2440-cpufreq.c:182:2: note: here > case 4: > ^~~~ > > Both look like the fallthrough is intentional, so add the new > "fallthrough;" keyword. > > Signed-off-by: Arnd Bergmann <arnd@...db.de> > --- > drivers/cpufreq/s3c2440-cpufreq.c | 2 ++ > 1 file changed, 2 insertions(+) I think I saw it but back then implicit-fallthrough was not an error :) LGTM: Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com> Best regards, Krzysztof
Powered by blists - more mailing lists