lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 4 Oct 2021 11:43:28 +0530 From: Viresh Kumar <viresh.kumar@...aro.org> To: Arnd Bergmann <arnd@...nel.org> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>, "Rafael J. Wysocki" <rafael@...nel.org>, Arnd Bergmann <arnd@...db.de>, linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org, linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] cpufreq: s3c244x: add fallthrough comments for switch On 27-09-21, 11:51, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@...db.de> > > Apparently nobody has so far caught this warning, I hit it in randconfig > build testing: > > drivers/cpufreq/s3c2440-cpufreq.c: In function 's3c2440_cpufreq_setdivs': > drivers/cpufreq/s3c2440-cpufreq.c:175:10: error: this statement may fall through [-Werror=implicit-fallthrough=] > camdiv |= S3C2440_CAMDIVN_HCLK3_HALF; > ^ > drivers/cpufreq/s3c2440-cpufreq.c:176:2: note: here > case 3: > ^~~~ > drivers/cpufreq/s3c2440-cpufreq.c:181:10: error: this statement may fall through [-Werror=implicit-fallthrough=] > camdiv |= S3C2440_CAMDIVN_HCLK4_HALF; > ^ > drivers/cpufreq/s3c2440-cpufreq.c:182:2: note: here > case 4: > ^~~~ > > Both look like the fallthrough is intentional, so add the new > "fallthrough;" keyword. > > Signed-off-by: Arnd Bergmann <arnd@...db.de> > --- > drivers/cpufreq/s3c2440-cpufreq.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/cpufreq/s3c2440-cpufreq.c b/drivers/cpufreq/s3c2440-cpufreq.c > index 148e8aedefa9..2011fb9c03a4 100644 > --- a/drivers/cpufreq/s3c2440-cpufreq.c > +++ b/drivers/cpufreq/s3c2440-cpufreq.c > @@ -173,12 +173,14 @@ static void s3c2440_cpufreq_setdivs(struct s3c_cpufreq_config *cfg) > > case 6: > camdiv |= S3C2440_CAMDIVN_HCLK3_HALF; > + fallthrough; > case 3: > clkdiv |= S3C2440_CLKDIVN_HDIVN_3_6; > break; > > case 8: > camdiv |= S3C2440_CAMDIVN_HCLK4_HALF; > + fallthrough; > case 4: > clkdiv |= S3C2440_CLKDIVN_HDIVN_4_8; > break; Applied. Thanks. -- viresh
Powered by blists - more mailing lists