lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Wed, 29 Sep 2021 06:58:35 +0800
From:   kernel test robot <lkp@...el.com>
To:     Daniel Borkmann <daniel@...earbox.net>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        Daniel Borkmann <daniel@...earbox.net>,
        linux-kernel@...r.kernel.org
Subject: [dborkman-bpf:pr/bpf-tstamp 3/3] net/ipv4/tcp.c:3901:50: error: no
 member named 'skb_mstamp_ns' in 'struct sk_buff'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/dborkman/bpf.git pr/bpf-tstamp
head:   f7d619a946e981177777983af26e9e31163ffb38
commit: f7d619a946e981177777983af26e9e31163ffb38 [3/3] net: skb clock bases
config: hexagon-randconfig-r041-20210928 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project dc6e8dfdfe7efecfda318d43a06fae18b40eb498)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/dborkman/bpf.git/commit/?id=f7d619a946e981177777983af26e9e31163ffb38
        git remote add dborkman-bpf https://git.kernel.org/pub/scm/linux/kernel/git/dborkman/bpf.git
        git fetch --no-tags dborkman-bpf pr/bpf-tstamp
        git checkout f7d619a946e981177777983af26e9e31163ffb38
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash net/ipv4/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from net/ipv4/tcp.c:274:
   include/net/tcp.h:812:27: error: no member named 'skb_mstamp_ns' in 'struct sk_buff'
           return tcp_ns_to_ts(skb->skb_mstamp_ns);
                               ~~~  ^
   include/net/tcp.h:818:22: error: no member named 'skb_mstamp_ns' in 'struct sk_buff'
           return div_u64(skb->skb_mstamp_ns, NSEC_PER_USEC);
                          ~~~  ^
   include/net/tcp.h:2367:8: error: no member named 'skb_mstamp_ns' in 'struct sk_buff'
                   skb->skb_mstamp_ns += (u64)tp->tcp_tx_delay * NSEC_PER_USEC;
                   ~~~  ^
>> net/ipv4/tcp.c:3901:50: error: no member named 'skb_mstamp_ns' in 'struct sk_buff'
           nla_put_u64_64bit(stats, TCP_NLA_EDT, orig_skb->skb_mstamp_ns,
                                                 ~~~~~~~~  ^
   4 errors generated.
--
   In file included from net/ipv4/tcp_output.c:40:
   include/net/tcp.h:812:27: error: no member named 'skb_mstamp_ns' in 'struct sk_buff'
           return tcp_ns_to_ts(skb->skb_mstamp_ns);
                               ~~~  ^
   include/net/tcp.h:818:22: error: no member named 'skb_mstamp_ns' in 'struct sk_buff'
           return div_u64(skb->skb_mstamp_ns, NSEC_PER_USEC);
                          ~~~  ^
   include/net/tcp.h:2367:8: error: no member named 'skb_mstamp_ns' in 'struct sk_buff'
                   skb->skb_mstamp_ns += (u64)tp->tcp_tx_delay * NSEC_PER_USEC;
                   ~~~  ^
>> net/ipv4/tcp_output.c:3564:32: error: expected ';' after expression
                   skb_set_tstamp_mono(skb, now)
                                                ^
                                                ;
>> net/ipv4/tcp_output.c:3790:37: error: no member named 'skb_mstamp_ns' in 'struct sk_buff'
           skb_set_tstamp_mono(syn, syn_data->skb_mstamp_ns);
                                    ~~~~~~~~  ^
   5 errors generated.


vim +3901 net/ipv4/tcp.c

e7ed11ee945438 Yousuk Seung    2021-01-20  3844  
48040793fa6003 Yousuk Seung    2020-07-30  3845  struct sk_buff *tcp_get_timestamping_opt_stats(const struct sock *sk,
e7ed11ee945438 Yousuk Seung    2021-01-20  3846  					       const struct sk_buff *orig_skb,
e7ed11ee945438 Yousuk Seung    2021-01-20  3847  					       const struct sk_buff *ack_skb)
1c885808e45601 Francis Yan     2016-11-27  3848  {
1c885808e45601 Francis Yan     2016-11-27  3849  	const struct tcp_sock *tp = tcp_sk(sk);
1c885808e45601 Francis Yan     2016-11-27  3850  	struct sk_buff *stats;
1c885808e45601 Francis Yan     2016-11-27  3851  	struct tcp_info info;
76a9ebe811fb3d Eric Dumazet    2018-10-15  3852  	unsigned long rate;
bb7c19f9601272 Wei Wang        2017-07-28  3853  	u64 rate64;
1c885808e45601 Francis Yan     2016-11-27  3854  
984988aa721884 Wei Wang        2018-07-31  3855  	stats = alloc_skb(tcp_opt_stats_get_size(), GFP_ATOMIC);
1c885808e45601 Francis Yan     2016-11-27  3856  	if (!stats)
1c885808e45601 Francis Yan     2016-11-27  3857  		return NULL;
1c885808e45601 Francis Yan     2016-11-27  3858  
1c885808e45601 Francis Yan     2016-11-27  3859  	tcp_get_info_chrono_stats(tp, &info);
1c885808e45601 Francis Yan     2016-11-27  3860  	nla_put_u64_64bit(stats, TCP_NLA_BUSY,
1c885808e45601 Francis Yan     2016-11-27  3861  			  info.tcpi_busy_time, TCP_NLA_PAD);
1c885808e45601 Francis Yan     2016-11-27  3862  	nla_put_u64_64bit(stats, TCP_NLA_RWND_LIMITED,
1c885808e45601 Francis Yan     2016-11-27  3863  			  info.tcpi_rwnd_limited, TCP_NLA_PAD);
1c885808e45601 Francis Yan     2016-11-27  3864  	nla_put_u64_64bit(stats, TCP_NLA_SNDBUF_LIMITED,
1c885808e45601 Francis Yan     2016-11-27  3865  			  info.tcpi_sndbuf_limited, TCP_NLA_PAD);
7e98102f489775 Yuchung Cheng   2017-01-27  3866  	nla_put_u64_64bit(stats, TCP_NLA_DATA_SEGS_OUT,
7e98102f489775 Yuchung Cheng   2017-01-27  3867  			  tp->data_segs_out, TCP_NLA_PAD);
7e98102f489775 Yuchung Cheng   2017-01-27  3868  	nla_put_u64_64bit(stats, TCP_NLA_TOTAL_RETRANS,
7e98102f489775 Yuchung Cheng   2017-01-27  3869  			  tp->total_retrans, TCP_NLA_PAD);
bb7c19f9601272 Wei Wang        2017-07-28  3870  
bb7c19f9601272 Wei Wang        2017-07-28  3871  	rate = READ_ONCE(sk->sk_pacing_rate);
76a9ebe811fb3d Eric Dumazet    2018-10-15  3872  	rate64 = (rate != ~0UL) ? rate : ~0ULL;
bb7c19f9601272 Wei Wang        2017-07-28  3873  	nla_put_u64_64bit(stats, TCP_NLA_PACING_RATE, rate64, TCP_NLA_PAD);
bb7c19f9601272 Wei Wang        2017-07-28  3874  
bb7c19f9601272 Wei Wang        2017-07-28  3875  	rate64 = tcp_compute_delivery_rate(tp);
bb7c19f9601272 Wei Wang        2017-07-28  3876  	nla_put_u64_64bit(stats, TCP_NLA_DELIVERY_RATE, rate64, TCP_NLA_PAD);
bb7c19f9601272 Wei Wang        2017-07-28  3877  
bb7c19f9601272 Wei Wang        2017-07-28  3878  	nla_put_u32(stats, TCP_NLA_SND_CWND, tp->snd_cwnd);
bb7c19f9601272 Wei Wang        2017-07-28  3879  	nla_put_u32(stats, TCP_NLA_REORDERING, tp->reordering);
bb7c19f9601272 Wei Wang        2017-07-28  3880  	nla_put_u32(stats, TCP_NLA_MIN_RTT, tcp_min_rtt(tp));
bb7c19f9601272 Wei Wang        2017-07-28  3881  
bb7c19f9601272 Wei Wang        2017-07-28  3882  	nla_put_u8(stats, TCP_NLA_RECUR_RETRANS, inet_csk(sk)->icsk_retransmits);
bb7c19f9601272 Wei Wang        2017-07-28  3883  	nla_put_u8(stats, TCP_NLA_DELIVERY_RATE_APP_LMT, !!tp->rate_app_limited);
7156d194a0772f Yousuk Seung    2018-03-16  3884  	nla_put_u32(stats, TCP_NLA_SND_SSTHRESH, tp->snd_ssthresh);
feb5f2ec646483 Yuchung Cheng   2018-04-17  3885  	nla_put_u32(stats, TCP_NLA_DELIVERED, tp->delivered);
feb5f2ec646483 Yuchung Cheng   2018-04-17  3886  	nla_put_u32(stats, TCP_NLA_DELIVERED_CE, tp->delivered_ce);
87ecc95d81d951 Priyaranjan Jha 2018-03-04  3887  
87ecc95d81d951 Priyaranjan Jha 2018-03-04  3888  	nla_put_u32(stats, TCP_NLA_SNDQ_SIZE, tp->write_seq - tp->snd_una);
be631892948060 Priyaranjan Jha 2018-03-04  3889  	nla_put_u8(stats, TCP_NLA_CA_STATE, inet_csk(sk)->icsk_ca_state);
feb5f2ec646483 Yuchung Cheng   2018-04-17  3890  
ba113c3aa79a7f Wei Wang        2018-07-31  3891  	nla_put_u64_64bit(stats, TCP_NLA_BYTES_SENT, tp->bytes_sent,
ba113c3aa79a7f Wei Wang        2018-07-31  3892  			  TCP_NLA_PAD);
fb31c9b9f6c85b Wei Wang        2018-07-31  3893  	nla_put_u64_64bit(stats, TCP_NLA_BYTES_RETRANS, tp->bytes_retrans,
fb31c9b9f6c85b Wei Wang        2018-07-31  3894  			  TCP_NLA_PAD);
7e10b6554ff2ce Wei Wang        2018-07-31  3895  	nla_put_u32(stats, TCP_NLA_DSACK_DUPS, tp->dsack_dups);
7ec65372ca5342 Wei Wang        2018-07-31  3896  	nla_put_u32(stats, TCP_NLA_REORD_SEEN, tp->reord_seen);
e8bd8fca6773ef Yousuk Seung    2018-11-15  3897  	nla_put_u32(stats, TCP_NLA_SRTT, tp->srtt_us >> 3);
32efcc06d2a15f Abdul Kabbani   2020-01-24  3898  	nla_put_u16(stats, TCP_NLA_TIMEOUT_REHASH, tp->timeout_rehash);
e08ab0b377a148 Yousuk Seung    2020-03-09  3899  	nla_put_u32(stats, TCP_NLA_BYTES_NOTSENT,
e08ab0b377a148 Yousuk Seung    2020-03-09  3900  		    max_t(int, 0, tp->write_seq - tp->snd_nxt));
48040793fa6003 Yousuk Seung    2020-07-30 @3901  	nla_put_u64_64bit(stats, TCP_NLA_EDT, orig_skb->skb_mstamp_ns,
48040793fa6003 Yousuk Seung    2020-07-30  3902  			  TCP_NLA_PAD);
e7ed11ee945438 Yousuk Seung    2021-01-20  3903  	if (ack_skb)
e7ed11ee945438 Yousuk Seung    2021-01-20  3904  		nla_put_u8(stats, TCP_NLA_TTL,
e7ed11ee945438 Yousuk Seung    2021-01-20  3905  			   tcp_skb_ttl_or_hop_limit(ack_skb));
ba113c3aa79a7f Wei Wang        2018-07-31  3906  
1c885808e45601 Francis Yan     2016-11-27  3907  	return stats;
1c885808e45601 Francis Yan     2016-11-27  3908  }
1c885808e45601 Francis Yan     2016-11-27  3909  

:::::: The code at line 3901 was first introduced by commit
:::::: 48040793fa6003d211f021c6ad273477bcd90d91 tcp: add earliest departure time to SCM_TIMESTAMPING_OPT_STATS

:::::: TO: Yousuk Seung <ysseung@...gle.com>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (31404 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ