linux-kernel - Re: [PATCH 1/3] rcu: Always inline rcu_dynticks_task*

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210928230347.GN880162@paulmck-ThinkPad-P17-Gen-1>
Date:   Tue, 28 Sep 2021 16:03:47 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     Peter Zijlstra <peterz@...radead.org>, sfr@...b.auug.org.au,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] rcu: Always inline rcu_dynticks_task*_{enter,exit}()

On Wed, Sep 29, 2021 at 12:35:14AM +0200, Thomas Gleixner wrote:
> On Tue, Sep 28 2021 at 10:40, Peter Zijlstra wrote:
> 
> > RCU managed to grow a few noinstr violations:
> >
> >   vmlinux.o: warning: objtool: rcu_dynticks_eqs_enter()+0x0: call to rcu_dynticks_task_trace_enter() leaves .noinstr.text section
> >   vmlinux.o: warning: objtool: rcu_dynticks_eqs_exit()+0xe: call to rcu_dynticks_task_trace_exit() leaves .noinstr.text section
> >
> > Fix them by adding __always_inline to the relevant trivial functions.
> >
> > Also replace the noinstr with __always_inline for the existing
> > rcu_dynticks_task_*() functions since noinstr would force noinline
> > them, even when empty, which seems silly.
> >
> > Fixes: 7d0c9c50c5a1 ("rcu-tasks: Avoid IPIing userspace/idle tasks if kernel is so built")
> > Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> > Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
> 
> Reviewed-by: Thomas Gleixner <tglx@...utronix.de>

Thank you!  I will apply to the pair of RCU commits at the next rebase.

							Thanx, Paul