linux-kernel - Re: sched: Remove pointless preemption disable in sched_submit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87d7b153-11a6-2f47-a5ed-abe10a294df3@kernel.dk>
Date:   Tue, 28 Sep 2021 08:41:08 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Thomas Gleixner <tglx@...utronix.de>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>, Peter Oskolkov <posk@...k.io>,
        Tejun Heo <tj@...nel.org>
Subject: Re: sched: Remove pointless preemption disable in sched_submit_work()

On 9/28/21 8:30 AM, Thomas Gleixner wrote:
> Neither wq_worker_sleeping() nor io_wq_worker_sleeping() require to be invoked
> with preemption disabled:
> 
>   - The worker flag checks operations only need to be serialized against
>     the worker thread itself.
> 
>   - The accounting and worker pool operations are serialized with locks.
> 
> which means that disabling preemption has neither a reason nor a
> value. Remove it.

Reviewed-by: Jens Axboe <axboe@...nel.dk>

-- 
Jens Axboe