linux-kernel - Re: [PATCH v2 3/4] iio: light: gp2ap002: Make use of the helper function dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210929170802.1ab77b3a@jic23-huawei>
Date:   Wed, 29 Sep 2021 17:08:02 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Cai Huoqing <caihuoqing@...du.com>
Cc:     Kevin Tsai <ktsai@...ellamicro.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Linus Walleij <linus.walleij@...aro.org>,
        <linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 3/4] iio: light: gp2ap002: Make use of the helper
 function dev_err_probe()

On Tue, 28 Sep 2021 09:41:54 +0800
Cai Huoqing <caihuoqing@...du.com> wrote:

> When possible use dev_err_probe help to properly deal with the
> PROBE_DEFER error, the benefit is that DEFER issue will be logged
> in the devices_deferred debugfs file.
> Using dev_err_probe() can reduce code size, and the error value
> gets printed.
> 
> Signed-off-by: Cai Huoqing <caihuoqing@...du.com>

There is an explicit return of -EPROBE_DEFER in here that we should
probably also handle.

https://elixir.bootlin.com/linux/latest/source/drivers/iio/light/gp2ap002.c#L508


I guess simplest option is
return dev_err_probe(dev, -EPROBE_DEFER, "no ADC, deferring\n");

> ---
>  drivers/iio/light/gp2ap002.c | 15 +++++++--------
>  1 file changed, 7 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/iio/light/gp2ap002.c b/drivers/iio/light/gp2ap002.c
> index f960be7d4001..724a3928ead1 100644
> --- a/drivers/iio/light/gp2ap002.c
> +++ b/drivers/iio/light/gp2ap002.c
> @@ -521,15 +521,14 @@ static int gp2ap002_probe(struct i2c_client *client,
>  	}
>  
>  	gp2ap002->vdd = devm_regulator_get(dev, "vdd");
> -	if (IS_ERR(gp2ap002->vdd)) {
> -		dev_err(dev, "failed to get VDD regulator\n");
> -		return PTR_ERR(gp2ap002->vdd);
> -	}
> +	if (IS_ERR(gp2ap002->vdd))
> +		return dev_err_probe(dev, PTR_ERR(gp2ap002->vdd),
> +				     "failed to get VDD regulator\n");
> +
>  	gp2ap002->vio = devm_regulator_get(dev, "vio");
> -	if (IS_ERR(gp2ap002->vio)) {
> -		dev_err(dev, "failed to get VIO regulator\n");
> -		return PTR_ERR(gp2ap002->vio);
> -	}
> +	if (IS_ERR(gp2ap002->vio))
> +		return dev_err_probe(dev, PTR_ERR(gp2ap002->vio),
> +				     "failed to get VIO regulator\n");
>  
>  	/* Operating voltage 2.4V .. 3.6V according to datasheet */
>  	ret = regulator_set_voltage(gp2ap002->vdd, 2400000, 3600000);