linux-kernel - Re: [PATCH v2 2/4] iio: light: cm36651: Make use of the helper function dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211007183637.0b9f364c@jic23-huawei>
Date:   Thu, 7 Oct 2021 18:36:37 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Cai Huoqing <caihuoqing@...du.com>
Cc:     Kevin Tsai <ktsai@...ellamicro.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Linus Walleij <linus.walleij@...aro.org>,
        <linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/4] iio: light: cm36651: Make use of the helper
 function dev_err_probe()

On Tue, 28 Sep 2021 09:41:53 +0800
Cai Huoqing <caihuoqing@...du.com> wrote:

> When possible use dev_err_probe help to properly deal with the
> PROBE_DEFER error, the benefit is that DEFER issue will be logged
> in the devices_deferred debugfs file.
> Using dev_err_probe() can reduce code size, and the error value
> gets printed.
> 
> Signed-off-by: Cai Huoqing <caihuoqing@...du.com>
To cut down on repeat sends I'm going to cherry pick individual patches
out of this series. Please send updates for the those patches I don't pick
up where I've requested changes.

Applied this patch to the togreg branch of iio.git and pushed out as testing
for 0-day to test it.

Thanks,

Jonathan

> ---
> v1->v2: Remove the separate line of PTR_ERR().
> 
>  drivers/iio/light/cm36651.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/iio/light/cm36651.c b/drivers/iio/light/cm36651.c
> index fd83a19929bc..c7cc4b0fe8b2 100644
> --- a/drivers/iio/light/cm36651.c
> +++ b/drivers/iio/light/cm36651.c
> @@ -632,10 +632,9 @@ static int cm36651_probe(struct i2c_client *client,
>  	cm36651 = iio_priv(indio_dev);
>  
>  	cm36651->vled_reg = devm_regulator_get(&client->dev, "vled");
> -	if (IS_ERR(cm36651->vled_reg)) {
> -		dev_err(&client->dev, "get regulator vled failed\n");
> -		return PTR_ERR(cm36651->vled_reg);
> -	}
> +	if (IS_ERR(cm36651->vled_reg))
> +		return dev_err_probe(&client->dev, PTR_ERR(cm36651->vled_reg),
> +				     "get regulator vled failed\n");
>  
>  	ret = regulator_enable(cm36651->vled_reg);
>  	if (ret) {