linux-kernel - Re: [PATCH v3 3/4] drm/rockchip: dsi: Fix unbalanced clock on probe error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210929180920.mczakda7msbojrxx@notapiano>
Date:   Wed, 29 Sep 2021 15:09:20 -0300
From:   Nícolas F. R. A. Prado 
        <nfraprado@...labora.com>
To:     Brian Norris <briannorris@...omium.org>
Cc:     Heiko Stübner <heiko@...ech.de>,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-rockchip@...ts.infradead.org,
        Sandy Huang <hjc@...k-chips.com>,
        Chen-Yu Tsai <wenst@...omium.org>,
        Thomas Hebb <tommyhebb@...il.com>
Subject: Re: [PATCH v3 3/4] drm/rockchip: dsi: Fix unbalanced clock on probe
 error

On Tue, Sep 28, 2021 at 02:35:51PM -0700, Brian Norris wrote:
> Our probe() function never enabled this clock, so we shouldn't disable
> it if we fail to probe the bridge.
> 
> Noted by inspection.
> 
> Fixes: 2d4f7bdafd70 ("drm/rockchip: dsi: migrate to use dw-mipi-dsi bridge driver")
> Signed-off-by: Brian Norris <briannorris@...omium.org>
> Reviewed-by: Chen-Yu Tsai <wenst@...omium.org>
> ---

Tested-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>