linux-kernel - Re: [smartpqi updates PATCH V2 06/11] smartpqi: avoid failing ios for offline devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c042f1af-678c-f635-9020-3d66ad755901@oracle.com>
Date:   Thu, 30 Sep 2021 13:23:27 -0500
From:   john.p.donnelly@...cle.com
To:     Don Brace <don.brace@...rochip.com>, hch@...radead.org,
        martin.petersen@...cle.com, jejb@...ux.vnet.ibm.com,
        linux-scsi@...r.kernel.org
Cc:     Kevin.Barnett@...rochip.com, scott.teel@...rochip.com,
        Justin.Lindley@...rochip.com, scott.benesh@...rochip.com,
        gerry.morong@...rochip.com, mahesh.rajashekhara@...rochip.com,
        mike.mcgowen@...rochip.com, murthy.bhat@...rochip.com,
        balsundar.p@...rochip.com, joseph.szczypek@....com,
        jeff@...onical.com, POSWALD@...e.com, mwilck@...e.com,
        pmenzel@...gen.mpg.de, linux-kernel@...r.kernel.org
Subject: Re: [smartpqi updates PATCH V2 06/11] smartpqi: avoid failing ios for
 offline devices

On 9/28/21 6:54 PM, Don Brace wrote:
> From: Mahesh Rajashekhara <mahesh.rajashekhara@...rochip.com>
> 
> Prevent kernel crash by failing outstanding I/O request
> when the OS takes device offline.
> 
> When posted IOs to the controller's inbound queue are
> not picked by the controller, the driver will halt the
> controller and take the controller offline.
> 
> When the driver takes the controller offline,
> the driver will fail all the outstanding requests which
> can sometime lead to an OS crash.
> 
> Reviewed-by: Scott Benesh <scott.benesh@...rochip.com>
> Reviewed-by: Scott Teel <scott.teel@...rochip.com>
> Signed-off-by: Mahesh Rajashekhara <mahesh.rajashekhara@...rochip.com>
> Signed-off-by: Don Brace <don.brace@...rochip.com>

Acked-by: John Donnelly <john.p.donnelly@...cle.com>


> ---
>   drivers/scsi/smartpqi/smartpqi_init.c | 9 ++++++++-
>   1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c
> index 838274d8fadf..c9f2a3d54663 100644
> --- a/drivers/scsi/smartpqi/smartpqi_init.c
> +++ b/drivers/scsi/smartpqi/smartpqi_init.c
> @@ -8544,6 +8544,7 @@ static void pqi_fail_all_outstanding_requests(struct pqi_ctrl_info *ctrl_info)
>   	unsigned int i;
>   	struct pqi_io_request *io_request;
>   	struct scsi_cmnd *scmd;
> +	struct scsi_device *sdev;
>   
>   	for (i = 0; i < ctrl_info->max_io_slots; i++) {
>   		io_request = &ctrl_info->io_request_pool[i];
> @@ -8552,7 +8553,13 @@ static void pqi_fail_all_outstanding_requests(struct pqi_ctrl_info *ctrl_info)
>   
>   		scmd = io_request->scmd;
>   		if (scmd) {
> -			set_host_byte(scmd, DID_NO_CONNECT);
> +			sdev = scmd->device;
> +			if (!sdev || !scsi_device_online(sdev)) {
> +				pqi_free_io_request(io_request);
> +				continue;
> +			} else {
> +				set_host_byte(scmd, DID_NO_CONNECT);
> +			}
>   		} else {
>   			io_request->status = -ENXIO;
>   			io_request->error_info =
>