linux-kernel - Re: [smartpqi updates PATCH V2 08/11] smartpqi: fix boot failure during lun rebuild

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <700a1f15-5d26-31b5-1a2e-b733883fcac3@oracle.com>
Date:   Thu, 30 Sep 2021 13:24:08 -0500
From:   john.p.donnelly@...cle.com
To:     Don Brace <don.brace@...rochip.com>, hch@...radead.org,
        martin.petersen@...cle.com, jejb@...ux.vnet.ibm.com,
        linux-scsi@...r.kernel.org
Cc:     Kevin.Barnett@...rochip.com, scott.teel@...rochip.com,
        Justin.Lindley@...rochip.com, scott.benesh@...rochip.com,
        gerry.morong@...rochip.com, mahesh.rajashekhara@...rochip.com,
        mike.mcgowen@...rochip.com, murthy.bhat@...rochip.com,
        balsundar.p@...rochip.com, joseph.szczypek@....com,
        jeff@...onical.com, POSWALD@...e.com, mwilck@...e.com,
        pmenzel@...gen.mpg.de, linux-kernel@...r.kernel.org
Subject: Re: [smartpqi updates PATCH V2 08/11] smartpqi: fix boot failure
 during lun rebuild

On 9/28/21 6:54 PM, Don Brace wrote:
> From: Mike McGowen <Mike.McGowen@...rochip.com>
> 
> Move the delay in the register polling loop to
> the beginning of the loop to ensure there is always
> a delay between writing the register and reading it.
> 
> Reviewed-by: Scott Benesh <scott.benesh@...rochip.com>
> Reviewed-by: Scott Teel <scott.teel@...rochip.com>
> Signed-off-by: Mike McGowen <Mike.McGowen@...rochip.com>
> Signed-off-by: Don Brace <don.brace@...rochip.com>


Acked-by: John Donnelly <john.p.donnelly@...cle.com>


> ---
>   drivers/scsi/smartpqi/smartpqi_init.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c
> index 1e27e6ba0159..c28eb7ea4a24 100644
> --- a/drivers/scsi/smartpqi/smartpqi_init.c
> +++ b/drivers/scsi/smartpqi/smartpqi_init.c
> @@ -4278,12 +4278,12 @@ static int pqi_create_admin_queues(struct pqi_ctrl_info *ctrl_info)
>   
>   	timeout = PQI_ADMIN_QUEUE_CREATE_TIMEOUT_JIFFIES + jiffies;
>   	while (1) {
> +		msleep(PQI_ADMIN_QUEUE_CREATE_POLL_INTERVAL_MSECS);
>   		status = readb(&pqi_registers->function_and_status_code);
>   		if (status == PQI_STATUS_IDLE)
>   			break;
>   		if (time_after(jiffies, timeout))
>   			return -ETIMEDOUT;
> -		msleep(PQI_ADMIN_QUEUE_CREATE_POLL_INTERVAL_MSECS);
>   	}
>   
>   	/*
>