linux-kernel - Re: [PATCH v17 08/15] arm64: kexec: configure EL2 vectors for kexec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210930081607.GA23250@willie-the-truck>
Date:   Thu, 30 Sep 2021 09:16:07 +0100
From:   Will Deacon <will@...nel.org>
To:     Pasha Tatashin <pasha.tatashin@...een.com>
Cc:     James Morris <jmorris@...ei.org>, Sasha Levin <sashal@...nel.org>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        kexec mailing list <kexec@...ts.infradead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Jonathan Corbet <corbet@....net>,
        Catalin Marinas <catalin.marinas@....com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Marc Zyngier <maz@...nel.org>,
        James Morse <james.morse@....com>,
        Vladimir Murzin <vladimir.murzin@....com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        linux-mm <linux-mm@...ck.org>,
        Mark Rutland <mark.rutland@....com>, steve.capper@....com,
        rfontana@...hat.com, Thomas Gleixner <tglx@...utronix.de>,
        Selin Dag <selindag@...il.com>,
        Tyler Hicks <tyhicks@...ux.microsoft.com>,
        Pingfan Liu <kernelfans@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        madvenka@...ux.microsoft.com
Subject: Re: [PATCH v17 08/15] arm64: kexec: configure EL2 vectors for kexec

On Wed, Sep 29, 2021 at 11:54:55PM -0400, Pasha Tatashin wrote:
> > > +/* Allocates pages for kexec page table */
> > > +static void *kexec_page_alloc(void *arg)
> > > +{
> > > +     struct kimage *kimage = (struct kimage *)arg;
> > > +     struct page *page = kimage_alloc_control_pages(kimage, 0);
> > > +
> > > +     if (!page)
> > > +             return NULL;
> > > +
> > > +     memset(page_address(page), 0, PAGE_SIZE);
> >
> > Hmm, I think we might be missing barriers here to ensure that the zeroes
> > are visible to the page-table walker before we plumb the page into the
> > page-table.
> >
> > Usually, that's taken care of by the smp_wmb() in __pXX_alloc() but I
> > can't see that here. Is it hiding?
> 
> Based on the comment in __pte_alloc() that smp_wmb() is needed in
> order to synchronize pte setup with other cpus prior to making it
> visible to them. This is not needed here. First, by the time these
> page tables are used the other cpus are offlined (kexec reboot code is
> single threaded). Second, we never insert any entry into a page table
> that is actively used by any cpu.

I think the comment there is wrong, but the barrier is still necessary.
How else do you guarantee that the page-table walker reads the zeroes from
the memset?

Will