linux-kernel - Re: [PATCHv3 1/3] EDAC/synopsys: use the quirk for version instead of ddr version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 30 Sep 2021 11:28:05 +0200
From:   Michal Simek <michal.simek@...inx.com>
To:     Dinh Nguyen <dinguyen@...nel.org>, <michal.simek@...inx.com>
CC:     <bp@...en8.de>, <mchehab@...nel.org>, <tony.luck@...el.com>,
        <james.morse@....com>, <rric@...nel.org>,
        <linux-kernel@...r.kernel.org>, <linux-edac@...r.kernel.org>
Subject: Re: [PATCHv3 1/3] EDAC/synopsys: use the quirk for version instead of
 ddr version



On 9/28/21 6:04 PM, Dinh Nguyen wrote:
> Version 2.40a supports DDR_ECC_INTR_SUPPORT for a quirk, so use that
> quirk to determine a call to setup_address_map().
> 
> Signed-off-by: Dinh Nguyen <dinguyen@...nel.org>
> ---
> v3: new patch
> ---
>  drivers/edac/synopsys_edac.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c
> index 7e7146b22c16..bf237fccb444 100644
> --- a/drivers/edac/synopsys_edac.c
> +++ b/drivers/edac/synopsys_edac.c
> @@ -1352,8 +1352,7 @@ static int mc_probe(struct platform_device *pdev)
>  		}
>  	}
>  
> -	if (of_device_is_compatible(pdev->dev.of_node,
> -				    "xlnx,zynqmp-ddrc-2.40a"))
> +	if (priv->p_data->quirks & DDR_ECC_INTR_SUPPORT)
>  		setup_address_map(priv);
>  #endif
>  
> 

Reviewed-by: Michal Simek <michal.simek@...inx.com>

Thanks,
Michal