linux-kernel - Re: [PATCH] staging: r8188eu: remove rtl8188e_silentreset_for_specific

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210930123937.GO2048@kadam>
Date:   Thu, 30 Sep 2021 15:39:37 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Michael Straube <straube.linux@...il.com>
Cc:     gregkh@...uxfoundation.org, Larry.Finger@...inger.net,
        phil@...lpotter.co.uk, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: remove
 rtl8188e_silentreset_for_specific_platform()

On Thu, Sep 30, 2021 at 10:55:42AM +0200, Michael Straube wrote:
> diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging/r8188eu/os_dep/ioctl_linux.c
> index dd47098ed1e5..852f8e0bbf64 100644
> --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c
> +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c
> @@ -4005,7 +4005,6 @@ static int rtw_dbg_port(struct net_device *dev,
>  		case 0x0f:
>  			if (extra_arg == 0) {
>  				DBG_88E("###### silent reset test.......#####\n");
> -				rtl8188e_silentreset_for_specific_platform(padapter);
>  			}

This introduces a new checkpatch warning about unnessary curly braces.
Just delete the whole if statement.

regards,
dan carpenter