linux-kernel - [PATCH] af_unix: add missing annotation at bpf_iter_unix_seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20211001234938.14806-1-jbi.octave@gmail.com>
Date:   Sat,  2 Oct 2021 00:49:37 +0100
From:   Jules Irenge <jbi.octave@...il.com>
To:     linux-kernel@...r.kernel.org
Cc:     Jules Irenge <jbi.octave@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        Cong Wang <cong.wang@...edance.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Rao Shoaib <Rao.Shoaib@...cle.com>,
        Jiang Wang <jiang.wang@...edance.com>,
        Kuniyuki Iwashima <kuniyu@...zon.co.jp>
Subject: [PATCH] af_unix: add missing annotation at bpf_iter_unix_seq_stop()

Sparse reports a warning at bpf_iter_unix_seq_stop()
The root cause is a missing annotation at bpf_iter_unix_seq_stop()

Add the missing __releases(unix_table_lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@...il.com>
---
 net/unix/af_unix.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
index efac5989edb5..9838d4d855e0 100644
--- a/net/unix/af_unix.c
+++ b/net/unix/af_unix.c
@@ -3291,6 +3291,7 @@ static int bpf_iter_unix_seq_show(struct seq_file *seq, void *v)
 }
 
 static void bpf_iter_unix_seq_stop(struct seq_file *seq, void *v)
+	__releases(unix_table_lock)
 {
 	struct bpf_iter_meta meta;
 	struct bpf_prog *prog;
-- 
2.32.0