linux-kernel - Re: [PATCH] af_unix: add missing annotation at bpf_iter_unix_seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211001180439.55bdc79f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 1 Oct 2021 18:04:39 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jules Irenge <jbi.octave@...il.com>
Cc:     linux-kernel@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        Cong Wang <cong.wang@...edance.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Rao Shoaib <Rao.Shoaib@...cle.com>,
        Jiang Wang <jiang.wang@...edance.com>,
        Kuniyuki Iwashima <kuniyu@...zon.co.jp>
Subject: Re: [PATCH] af_unix: add missing annotation at
 bpf_iter_unix_seq_stop()

On Sat,  2 Oct 2021 00:49:37 +0100 Jules Irenge wrote:
> Sparse reports a warning at bpf_iter_unix_seq_stop()
> The root cause is a missing annotation at bpf_iter_unix_seq_stop()
> 
> Add the missing __releases(unix_table_lock) annotation
> 
> Signed-off-by: Jules Irenge <jbi.octave@...il.com>
> ---
>  net/unix/af_unix.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
> index efac5989edb5..9838d4d855e0 100644
> --- a/net/unix/af_unix.c
> +++ b/net/unix/af_unix.c
> @@ -3291,6 +3291,7 @@ static int bpf_iter_unix_seq_show(struct seq_file *seq, void *v)
>  }
>  
>  static void bpf_iter_unix_seq_stop(struct seq_file *seq, void *v)
> +	__releases(unix_table_lock)
>  {
>  	struct bpf_iter_meta meta;
>  	struct bpf_prog *prog;

You need to CC bpf@...r... and netdev@...r...

You can drop the CC for linux-kernel@, approximately nobody reads that.