linux-kernel - Re: [PATCH] memblock: Neaten logging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6573ccd25ce80f5e28ed35e4c88c898b0f994fbc.camel@perches.com>
Date:   Thu, 30 Sep 2021 18:27:15 -0700
From:   Joe Perches <joe@...ches.com>
To:     Mike Rapoport <rppt@...nel.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        linux-mm <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] memblock: Neaten logging

On Thu, 2021-09-30 at 14:12 -0700, Mike Rapoport wrote:
> Hi Joe,
> 
> On Wed, Sep 29, 2021 at 09:43:14PM -0700, Joe Perches wrote:
> > Use more typical kernel logging styles.
> > 
> > o Add and use #define pr_fmt KBUILD_MODNAME ": " fmt
> 
> I don't see it as an improvement. On the contrary, the output becomes
> somewhat tautological:

And rather easier to grep as the prefix is constant.

> What is the base commit for this patch?
> It seems it missed a pr_warn in memblock_cap_memory_range()...

linus' master.