linux-kernel - Re: [PATCH] memblock: Neaten logging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YVYoVNFBMER4bjrT@kernel.org>
Date:   Thu, 30 Sep 2021 14:12:52 -0700
From:   Mike Rapoport <rppt@...nel.org>
To:     Joe Perches <joe@...ches.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        linux-mm <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] memblock: Neaten logging

Hi Joe,

On Wed, Sep 29, 2021 at 09:43:14PM -0700, Joe Perches wrote:
> Use more typical kernel logging styles.
> 
> o Add and use #define pr_fmt KBUILD_MODNAME ": " fmt

I don't see it as an improvement. On the contrary, the output becomes
somewhat tautological:

memblock: memblock_reserve: smp_scan_config+0xa5/0xe9: [0x00000000000f5a60-0x00000000000f5a6f]
memblock: memblock_reserve: smp_scan_config+0xbc/0xe9: [0x00000000000f5a70-0x00000000000f5b83]
memblock: memblock_reserve: setup_arch+0x5d8/0xbcd: [0x0000000002e00000-0x0000000002e10fff]
memblock: memblock_add: e820__memblock_setup+0x5e/0x76: [0x0000000000001000-0x000000000009fbff]
memblock: memblock_add: e820__memblock_setup+0x5e/0x76: [0x0000000000100000-0x00000000bffdcfff]
memblock: memblock_add: e820__memblock_setup+0x5e/0x76: [0x0000000100000000-0x000000013fffffff]

And the output of memblock_dump_all() is perfectly fine without the prefix.

> o Neaten memblock_dbg to use %s: %pS: to output __func__ and caller
> o Convert existing uses of pr_<level> and memblock_dbg appropriately
> 
> Logging output is now always prefixed with 'memblock: '
> Debugging output is now prefixed with 'memblock: ', function and caller
> 
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  mm/memblock.c | 59 ++++++++++++++++++++++++++---------------------------------
>  1 file changed, 26 insertions(+), 33 deletions(-)

What is the base commit for this patch?
It seems it missed a pr_warn in memblock_cap_memory_range()...
 
> diff --git a/mm/memblock.c b/mm/memblock.c
> index 184dcd2e5d99..405335c966a8 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c

-- 
Sincerely yours,
Mike.