linux-kernel - Re: [PATCH v1 1/1] virt: acrn: Drop internal kernel type from ABI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YVciKWdHJMaEwQu6@smile.fi.intel.com>
Date:   Fri, 1 Oct 2021 17:58:49 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Reinette Chatre <reinette.chatre@...el.com>,
        Shuo Liu <shuo.a.liu@...el.com>,
        Zhi Wang <zhi.a.wang@...el.com>, linux-kernel@...r.kernel.org,
        Fei Li <fei1.li@...el.com>
Subject: Re: [PATCH v1 1/1] virt: acrn: Drop internal kernel type from ABI

On Fri, Oct 01, 2021 at 04:01:41PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Oct 01, 2021 at 04:56:44PM +0300, Andy Shevchenko wrote:
> > guid_t is internal type of the kernel which is mistakenly had been exposed
> > to the user space. Replace it with raw buffers.
> 
> Wait, why is it a mistake to expose it to userspace?  What does this
> conflict with?  Is it a namespace issue?  Or something else?

It is the type which is defined solely for kernel use and what user space
should do is to use types defined by respective libraries, such as libuuid.

If you read the commit message to the end, you will notice that I have
mentioned the possible scenario what happened here. They seems misusing
guid_t as uuid_t, but the latter is not available for the users from
the kernel headers (and this is good). So this is an exact example why
guid_t shouldn't be exposed.

-- 
With Best Regards,
Andy Shevchenko