linux-kernel - Re: [PATCH v1 1/1] seq_file: Move seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VdQeNnNqVtp00iD6Wo+5GOs1AxSKqSDmxxx6D-AbAJ2AQ@mail.gmail.com>
Date:   Sat, 2 Oct 2021 10:57:38 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Linux FS Devel <linux-fsdevel@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Jonathan Cameron <jic23@...nel.org>
Subject: Re: [PATCH v1 1/1] seq_file: Move seq_escape() to a header

On Sat, Oct 2, 2021 at 2:41 AM Andrew Morton <akpm@...ux-foundation.org> wrote:
> On Fri,  1 Oct 2021 15:29:17 +0300 Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
>
> > Move seq_escape() to the header as inliner.
>
> Some reason for doing this would be nice.  Does it make the kernel
> smaller?  Is this performance-sensitive?

It reduces exported namespace, hence makes it smaller, yes.

...

> > +#include <linux/string_helpers.h>
>
> Why was this added?

The definition of ESCAPE_OCTAL is there.

-- 
With Best Regards,
Andy Shevchenko