linux-kernel - [PATCH] checksyscalls: Unconditionally ignore fstat{,at}64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sat,  2 Oct 2021 16:57:13 -0700
From:   Palmer Dabbelt <palmer@...belt.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Palmer Dabbelt <palmerdabbelt@...gle.com>,
        Arnd Bergmann <arnd@...db.de>, david@...hat.com,
        catalin.marinas@....com, Stephen Rothwell <sfr@...b.auug.org.au>,
        rppt@...nel.org, linux-kernel@...r.kernel.org,
        kernel-team@...roid.com
Subject: [PATCH] checksyscalls: Unconditionally ignore fstat{,at}64

From: Palmer Dabbelt <palmerdabbelt@...gle.com>

These can be replaced by statx().  Since rv32 has a 64-bit time_t we
just never ended up with them in the first place.

Suggested-by: Arnd Bergmann <arnd@...db.de>
Signed-off-by: Palmer Dabbelt <palmerdabbelt@...gle.com>
---
Happy to take this through the RISC-V tree, as it's fixing a build warning
(that's being promoted to an error for me, not sure why).  I'm just not all
that familiar with how this one works.

Arnd suggested putting these here, but not exactly doing it this way.
---
 scripts/checksyscalls.sh | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/scripts/checksyscalls.sh b/scripts/checksyscalls.sh
index fd9777f63f14..9dbab13329fa 100755
--- a/scripts/checksyscalls.sh
+++ b/scripts/checksyscalls.sh
@@ -82,10 +82,8 @@ cat << EOF
 #define __IGNORE_truncate64
 #define __IGNORE_stat64
 #define __IGNORE_lstat64
-#define __IGNORE_fstat64
 #define __IGNORE_fcntl64
 #define __IGNORE_fadvise64_64
-#define __IGNORE_fstatat64
 #define __IGNORE_fstatfs64
 #define __IGNORE_statfs64
 #define __IGNORE_llseek
@@ -253,6 +251,10 @@ cat << EOF
 #define __IGNORE_getpmsg
 #define __IGNORE_putpmsg
 #define __IGNORE_vserver
+
+/* 64-bit ports never needed these, and new 32-bit ports can use statx */
+#define __IGNORE_fstat64
+#define __IGNORE_fstatat64
 EOF
 }
 
-- 
2.33.0.800.g4c38ced690-goog