lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 4 Oct 2021 08:16:39 +0100 From: Lee Jones <lee.jones@...aro.org> To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> Cc: Orlando Chamberlain <redecorating@...tonmail.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] mfd: intel-lpss: Add support for MacBookPro16,2 UART On Fri, 01 Oct 2021, Andy Shevchenko wrote: > On Fri, Oct 01, 2021 at 07:14:12PM +0100, Lee Jones wrote: > > On Fri, 01 Oct 2021, Andy Shevchenko wrote: > > > On Fri, Oct 01, 2021 at 08:51:46AM +0000, Orlando Chamberlain wrote: > > ... > > > > > + /* MacBookPro16,2 */ > > > > > > Use > > > > > > /* ICL-N */ > > > > > > here. > > > > Why is that? > > It's a standard way of representing PCH/SoC in the comments in this driver: > - MacBookPro16,2 is not a name of the PCH/SoC > - MacBookPro16,2 is possible not the solely hardware of this chip Okay, that's fine. > Why not to mention this name in the commit message? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Powered by blists - more mailing lists