lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 4 Oct 2021 07:53:54 +0100 From: Lee Jones <lee.jones@...aro.org> To: Orlando Chamberlain <redecorating@...tonmail.com> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCHv3] mfd: intel-lpss: Add support for MacBookPro16,2 ICL-N UART On Sat, 02 Oct 2021, Orlando Chamberlain wrote: > On Sat, 02 Oct 2021 21:04:30 +1000 > "Andy Shevchenko" <andriy.shevchenko@...ux.intel.com> wrote: > > > You ignoring my Reviewed-by tag. Any reason why? > > Sorry, I'm new to this and assumed it needed to be reviewed again after > any changes (including to the commit message). > > > Besides that you are posting patches as continuation of the thread. > > It may be problematic for some tools, like `b4`, although I dunno if > > Lee is using such tools. > > I'll make a v4 with the reviewed-by line. I'll make it a reply to the > first version of the patch, and hopefully that'll be the first place > tools like `b4` look. You only need to add the *-by lines to *new* submissions. Please don't submit new versions just to add *-by lines. `b4` doesn't support replied-to patch-sets, so even replying-to the very first submission/version won't help here. Submissions need to be completely separate. FWIW: As it happens, I do use `b4`, but I don't use the auto-apply-set functionality. I either apply patches individually or select (tag) the ones I wish to apply, so I do not suffer from this problem like some others do. > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> > > > > > Signed-off-by: Orlando Chamberlain <redecorating@...tonmail.com> > > > --- > > > v2->v3: Mention "ICL-N" in commit message. > > > drivers/mfd/intel-lpss-pci.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/mfd/intel-lpss-pci.c > > > b/drivers/mfd/intel-lpss-pci.c index c54d19fb184c..a872b4485eac > > > 100644 --- a/drivers/mfd/intel-lpss-pci.c > > > +++ b/drivers/mfd/intel-lpss-pci.c > > > @@ -253,6 +253,8 @@ static const struct pci_device_id > > > intel_lpss_pci_ids[] = { { PCI_VDEVICE(INTEL, 0x34ea), > > > (kernel_ulong_t)&bxt_i2c_info }, { PCI_VDEVICE(INTEL, 0x34eb), > > > (kernel_ulong_t)&bxt_i2c_info }, { PCI_VDEVICE(INTEL, 0x34fb), > > > (kernel_ulong_t)&spt_info }, > > > + /* ICL-N */ > > > + { PCI_VDEVICE(INTEL, 0x38a8), > > > (kernel_ulong_t)&bxt_uart_info }, /* TGL-H */ > > > { PCI_VDEVICE(INTEL, 0x43a7), > > > (kernel_ulong_t)&bxt_uart_info }, { PCI_VDEVICE(INTEL, 0x43a8), > > > (kernel_ulong_t)&bxt_uart_info }, -- > > > 2.33.0 > > > > > > > > > > > -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Powered by blists - more mailing lists