linux-kernel - Re: [PATCH] opp: Fix required-opps phandle array count check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 4 Oct 2021 12:23:41 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Pavankumar Kondeti <pkondeti@...eaurora.org>
Cc:     linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        "Rafael J . Wysocki" <rjw@...ysocki.net>,
        Rajendra Nayak <rnayak@...eaurora.org>,
        Viresh Kumar <vireshk@...nel.org>, Nishanth Menon <nm@...com>,
        Stephen Boyd <sboyd@...nel.org>
Subject: Re: [PATCH] opp: Fix required-opps phandle array count check

On 30-09-21, 15:39, Pavankumar Kondeti wrote:
> The 'required-opps' property is optional. So of_count_phandle_with_args()
> can return -ENOENT when queried for required-opps. Handle this case.
> 
> Signed-off-by: Pavankumar Kondeti <pkondeti@...eaurora.org>
> ---
>  drivers/opp/of.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/opp/of.c b/drivers/opp/of.c
> index 2a97c65..5437085 100644
> --- a/drivers/opp/of.c
> +++ b/drivers/opp/of.c
> @@ -170,7 +170,7 @@ static void _opp_table_alloc_required_tables(struct opp_table *opp_table,
>  	}
>  
>  	count = of_count_phandle_with_args(np, "required-opps", NULL);
> -	if (!count)
> +	if (count <= 0)
>  		goto put_np;
>  
>  	required_opp_tables = kcalloc(count, sizeof(*required_opp_tables),

Applied. Thanks.

-- 
viresh