linux-kernel - Re: [PATCH v3] usb: gadget: storage: add support for media larger than 2T

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211005141958.GA621017@rowland.harvard.edu>
Date:   Tue, 5 Oct 2021 10:19:58 -0400
From:   Alan Stern <stern@...land.harvard.edu>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Nikita Yushchenko <nikita.yoush@...entembedded.com>,
        Felipe Balbi <balbi@...nel.org>, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Petr Nechaev <petr.nechaev@...entembedded.com>
Subject: Re: [PATCH v3] usb: gadget: storage: add support for media larger
 than 2T

On Tue, Oct 05, 2021 at 01:07:58PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Sep 21, 2021 at 05:59:02PM +0300, Nikita Yushchenko wrote:
> > This adds support for READ_CAPACITY(16), READ(16) and WRITE(16)
> > commands, and fixes READ_CAPACITY command to return 0xffffffff if
> > media size does not fit in 32 bits.
> > 
> > This makes f_mass_storage to export a 16T disk array correctly.
> > 
> > Signed-off-by: Nikita Yushchenko <nikita.yoush@...entembedded.com>
> > ---
> > v3:
> > - added this changelog
> > 
> > v2:
> > - fixed call to check_command() for READ_CAPACITY(16)
> > - fixed alphabetical order of commands in switch statement
> > - renamed variable, added comments, and fixed formatting, per advices by
> >   Alan Stern <stern@...land.harvard.edu>
> 
> Felipe and Alan, any objections to this change?

No objections.  In fact, I already sent my Acked-by for v2 of the 
patch (which is the same as v3):

https://marc.info/?l=linux-usb&m=163165151506682&w=2

Alan Stern