linux-kernel - Re: [PATCH v3] usb: gadget: storage: add support for media larger than 2T

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <875yubznck.fsf@kernel.org>
Date:   Tue, 05 Oct 2021 15:07:11 +0300
From:   Felipe Balbi <balbi@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Nikita Yushchenko <nikita.yoush@...entembedded.com>,
        Alan Stern <stern@...land.harvard.edu>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Petr Nechaev <petr.nechaev@...entembedded.com>
Subject: Re: [PATCH v3] usb: gadget: storage: add support for media larger
 than 2T


Hi,

Greg Kroah-Hartman <gregkh@...uxfoundation.org> writes:

> On Tue, Sep 21, 2021 at 05:59:02PM +0300, Nikita Yushchenko wrote:
>> This adds support for READ_CAPACITY(16), READ(16) and WRITE(16)
>> commands, and fixes READ_CAPACITY command to return 0xffffffff if
>> media size does not fit in 32 bits.
>> 
>> This makes f_mass_storage to export a 16T disk array correctly.
>> 
>> Signed-off-by: Nikita Yushchenko <nikita.yoush@...entembedded.com>
>> ---
>> v3:
>> - added this changelog
>> 
>> v2:
>> - fixed call to check_command() for READ_CAPACITY(16)
>> - fixed alphabetical order of commands in switch statement
>> - renamed variable, added comments, and fixed formatting, per advices by
>>   Alan Stern <stern@...land.harvard.edu>
>
> Felipe and Alan, any objections to this change?

none from me, but I'd definitely wait for Alan's comments as he's the
one who understands the storage gadget inside out :-)

cheers

-- 
balbi