[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAKUd0B_vh5gxsjHVAoC4YTpwUA8vj6qKovza8OM391koM2t+hQ@mail.gmail.com>
Date: Tue, 5 Oct 2021 12:46:36 -0700
From: Ramji Jiyani <ramjiyani@...gle.com>
To: Jeff Moyer <jmoyer@...hat.com>
Cc: Benjamin LaHaise <bcrl@...ck.org>,
Alexander Viro <viro@...iv.linux.org.uk>,
Arnd Bergmann <arnd@...db.de>, kernel-team@...roid.com,
linux-aio@...ck.org, linux-fsdevel@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org
Subject: Re: [RESEND PATCH] aio: Add support for the POLLFREE
Hi Jeff:
On Tue, Oct 5, 2021 at 12:33 PM Jeff Moyer <jmoyer@...hat.com> wrote:
>
> Hi, Ramji,
>
> Thanks for the explanation of the use after free. I went ahead and
> ran the patch through the libaio test suite and it passed.
>
Thanks for taking time to test and providing feedback.
> > -#define POLLFREE (__force __poll_t)0x4000 /* currently only for epoll */
> > +#define POLLFREE ((__force __poll_t)0x4000)
>
> You added parenthesis, here, and I'm not sure if that's a necessary part
> of this patch.
I added parenthesis to silence the checkpatch script. Should I just ignore it?
I'll send v2 with the change, if it is required.
>
> Other than that:
>
> Reviewed-by: Jeff Moyer <jmoyer@...hat.com>
>
Thanks,
Ramji
Powered by blists - more mailing lists