linux-kernel - Re: [RESEND PATCH] aio: Add support for the POLLFREE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <x49ee8zjlej.fsf@segfault.boston.devel.redhat.com>
Date:   Tue, 05 Oct 2021 15:56:20 -0400
From:   Jeff Moyer <jmoyer@...hat.com>
To:     Ramji Jiyani <ramjiyani@...gle.com>
Cc:     Benjamin LaHaise <bcrl@...ck.org>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Arnd Bergmann <arnd@...db.de>, kernel-team@...roid.com,
        linux-aio@...ck.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org
Subject: Re: [RESEND PATCH] aio: Add support for the POLLFREE

Hi, Ramji,

Ramji Jiyani <ramjiyani@...gle.com> writes:

> Hi Jeff:
>
> On Tue, Oct 5, 2021 at 12:33 PM Jeff Moyer <jmoyer@...hat.com> wrote:
>>
>> Hi, Ramji,
>>
>> Thanks for the explanation of the use after free.  I went ahead and
>> ran the patch through the libaio test suite and it passed.
>>
>
> Thanks for taking time to test and providing feedback.
>
>> > -#define POLLFREE     (__force __poll_t)0x4000        /* currently only for epoll */
>> > +#define POLLFREE     ((__force __poll_t)0x4000)
>>
>> You added parenthesis, here, and I'm not sure if that's a necessary part
>> of this patch.
>
> I added parenthesis to silence the checkpatch script. Should I just ignore it?
> I'll send v2 with the change, if it is required.

None of the other #defines in that file use parens, so it would, at the
very least, be inconsistent.  I would leave the the parens out.

Cheers,
Jeff