lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 05 Oct 2021 15:56:20 -0400
From:   Jeff Moyer <>
To:     Ramji Jiyani <>
Cc:     Benjamin LaHaise <>,
        Alexander Viro <>,
        Arnd Bergmann <>,,,,,
Subject: Re: [RESEND PATCH] aio: Add support for the POLLFREE

Hi, Ramji,

Ramji Jiyani <> writes:

> Hi Jeff:
> On Tue, Oct 5, 2021 at 12:33 PM Jeff Moyer <> wrote:
>> Hi, Ramji,
>> Thanks for the explanation of the use after free.  I went ahead and
>> ran the patch through the libaio test suite and it passed.
> Thanks for taking time to test and providing feedback.
>> > -#define POLLFREE     (__force __poll_t)0x4000        /* currently only for epoll */
>> > +#define POLLFREE     ((__force __poll_t)0x4000)
>> You added parenthesis, here, and I'm not sure if that's a necessary part
>> of this patch.
> I added parenthesis to silence the checkpatch script. Should I just ignore it?
> I'll send v2 with the change, if it is required.

None of the other #defines in that file use parens, so it would, at the
very least, be inconsistent.  I would leave the the parens out.


Powered by blists - more mailing lists