linux-kernel - Re: [PATCH 5/9] x86/Kconfig: remove reference to obsolete APB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 5 Oct 2021 21:57:29 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
        Randy Dunlap <rdunlap@...radead.org>,
        "H . Peter Anvin" <hpa@...or.com>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Lubomir Rintel <lkundrak@...sk>, Pavel Machek <pavel@....cz>,
        Lee Jones <lee.jones@...aro.org>,
        "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        platform-driver-x86@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/9] x86/Kconfig: remove reference to obsolete APB_TIMER
 config

On Tue, Aug 03, 2021 at 01:35:27PM +0200, Lukas Bulwahn wrote:
> Commit 1b79fc4f2bfd ("x86/apb_timer: Remove driver for deprecated
> platform") removes the definition of the config APB_TIMER in
> ./arch/x86/Kconfig, but misses to remove a reference to it in config
> X86_INTEL_MID.
> 
> Fortunately, ./scripts/checkkconfigsymbols.py warns:
> 
> APB_TIMER
> Referencing files: arch/x86/Kconfig
> 
> Remove this reference to the obsolete config.
> 
> Fixes: 1b79fc4f2bfd ("x86/apb_timer: Remove driver for deprecated platform")
> Suggested-by: Randy Dunlap <rdunlap@...radead.org>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>
> ---
>  arch/x86/Kconfig | 1 -
>  1 file changed, 1 deletion(-)

I've combined that and the previous one into a single patch since
they're pretty trivial:

---
From: Lukas Bulwahn <lukas.bulwahn@...il.com>
Date: Tue, 3 Aug 2021 13:35:26 +0200
Subject: [PATCH] x86/Kconfig: Remove references to obsolete Kconfig symbols

Remove two symbols referenced in Kconfig which have been removed
previously by:

  ef3c67b6454b ("mfd: intel_msic: Remove driver for deprecated platform")
  1b79fc4f2bfd ("x86/apb_timer: Remove driver for deprecated platform")

Detected by scripts/checkkconfigsymbols.py.

  [ bp: Merge into a single patch. ]

Suggested-by: Randy Dunlap <rdunlap@...radead.org>
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>
Signed-off-by: Borislav Petkov <bp@...e.de>
Link: https://lkml.kernel.org/r/20210803113531.30720-5-lukas.bulwahn@gmail.com
---
 arch/x86/Kconfig | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 4e001bbbb425..b79e88ee6627 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -605,9 +605,7 @@ config X86_INTEL_MID
 	depends on X86_IO_APIC
 	select I2C
 	select DW_APB_TIMER
-	select APB_TIMER
 	select INTEL_SCU_PCI
-	select MFD_INTEL_MSIC
 	help
 	  Select to build a kernel capable of supporting Intel MID (Mobile
 	  Internet Device) platform systems which do not have the PCI legacy
-- 
2.29.2


-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette