lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 6 Oct 2021 00:06:11 +0200
From:   Michael Straube <straube.linux@...il.com>
To:     Martin Kaiser <martin@...ser.cx>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/9] staging: r8188eu: remove write-only HwRxPageSize

On 10/5/21 22:08, Martin Kaiser wrote:
> HwRxPageSize from struct hal_data_8188e is set but never read. Remove
> the component and the code to initialise it.
> 
> Signed-off-by: Martin Kaiser <martin@...ser.cx>
> ---
>   drivers/staging/r8188eu/hal/usb_halinit.c     | 20 -------------------
>   .../staging/r8188eu/include/rtl8188e_hal.h    |  1 -
>   .../staging/r8188eu/include/rtl8188e_spec.h   |  4 ----
>   3 files changed, 25 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c
> index ab7b80144403..f71f25e234ab 100644
> --- a/drivers/staging/r8188eu/hal/usb_halinit.c
> +++ b/drivers/staging/r8188eu/hal/usb_halinit.c
> @@ -524,26 +524,6 @@ usb_AggSettingRxUpdate(
>   		/*  TODO: */
>   		break;
>   	}
> -
> -	switch (PBP_128) {
> -	case PBP_128:
> -		haldata->HwRxPageSize = 128;
> -		break;
> -	case PBP_64:
> -		haldata->HwRxPageSize = 64;
> -		break;
> -	case PBP_256:
> -		haldata->HwRxPageSize = 256;
> -		break;
> -	case PBP_512:
> -		haldata->HwRxPageSize = 512;
> -		break;
> -	case PBP_1024:
> -		haldata->HwRxPageSize = 1024;
> -		break;
> -	default:
> -		break;
> -	}
>   }	/*  usb_AggSettingRxUpdate */
>   
>   static void InitUsbAggregationSetting(struct adapter *Adapter)
> diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/staging/r8188eu/include/rtl8188e_hal.h
> index 08dedf4c91b8..fc6acbba17e7 100644
> --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h
> +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h
> @@ -360,7 +360,6 @@ struct hal_data_8188e {
>   	u8	C2hArray[16];
>   	u8	UsbTxAggMode;
>   	u8	UsbTxAggDescNum;
> -	u16	HwRxPageSize;		/*  Hardware setting */
>   	u32	MaxUsbRxAggBlock;
>   
>   	enum usb_rx_agg_mode UsbRxAggMode;
> diff --git a/drivers/staging/r8188eu/include/rtl8188e_spec.h b/drivers/staging/r8188eu/include/rtl8188e_spec.h
> index 1c96f7b81245..01aeaa4ac605 100644
> --- a/drivers/staging/r8188eu/include/rtl8188e_spec.h
> +++ b/drivers/staging/r8188eu/include/rtl8188e_spec.h
> @@ -893,11 +893,7 @@ Current IOREG MAP
>   #define _PSRX(x)			(x)
>   #define _PSTX(x)			((x) << 4)
>   
> -#define PBP_64				0x0
>   #define PBP_128				0x1
> -#define PBP_256				0x2
> -#define PBP_512				0x3
> -#define PBP_1024			0x4
>   
>   /* 2 TX/RXDMA */
>   #define RXDMA_ARBBW_EN			BIT(0)
> 

Looks good to me.

Acked-by: Michael Straube <straube.linux@...il.com>

Thanks,
Michael

Powered by blists - more mailing lists