linux-kernel - Re: [PATCH 4/9] staging: r8188eu: remove unused IntrMask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d6f016e1-b6d3-05eb-1880-9346580aca3f@gmail.com>
Date:   Wed, 6 Oct 2021 00:06:26 +0200
From:   Michael Straube <straube.linux@...il.com>
To:     Martin Kaiser <martin@...ser.cx>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/9] staging: r8188eu: remove unused IntrMask

On 10/5/21 22:08, Martin Kaiser wrote:
> The IntrMask array is set but never read. Remove it.
> 
> Signed-off-by: Martin Kaiser <martin@...ser.cx>
> ---
>   drivers/staging/r8188eu/hal/usb_halinit.c      | 3 ---
>   drivers/staging/r8188eu/include/rtl8188e_hal.h | 1 -
>   2 files changed, 4 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c
> index f71f25e234ab..bd3ba6ab364f 100644
> --- a/drivers/staging/r8188eu/hal/usb_halinit.c
> +++ b/drivers/staging/r8188eu/hal/usb_halinit.c
> @@ -119,18 +119,15 @@ static void _InitInterrupt(struct adapter *Adapter)
>   {
>   	u32 imr, imr_ex;
>   	u8  usb_opt;
> -	struct hal_data_8188e	*haldata = GET_HAL_DATA(Adapter);
>   
>   	/* HISR write one to clear */
>   	rtw_write32(Adapter, REG_HISR_88E, 0xFFFFFFFF);
>   	/*  HIMR - */
>   	imr = IMR_PSTIMEOUT_88E | IMR_TBDER_88E | IMR_CPWM_88E | IMR_CPWM2_88E;
>   	rtw_write32(Adapter, REG_HIMR_88E, imr);
> -	haldata->IntrMask[0] = imr;
>   
>   	imr_ex = IMR_TXERR_88E | IMR_RXERR_88E | IMR_TXFOVW_88E | IMR_RXFOVW_88E;
>   	rtw_write32(Adapter, REG_HIMRE_88E, imr_ex);
> -	haldata->IntrMask[1] = imr_ex;
>   
>   	/*  REG_USB_SPECIAL_OPTION - BIT(4) */
>   	/*  0; Use interrupt endpoint to upload interrupt pkt */
> diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/staging/r8188eu/include/rtl8188e_hal.h
> index fc6acbba17e7..bfe32864ded6 100644
> --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h
> +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h
> @@ -356,7 +356,6 @@ struct hal_data_8188e {
>   
>   	/*  Interrupt relatd register information. */
>   	u32	IntArray[3];/* HISR0,HISR1,HSISR */
> -	u32	IntrMask[3];
>   	u8	C2hArray[16];
>   	u8	UsbTxAggMode;
>   	u8	UsbTxAggDescNum;
> 

Looks good to me.

Acked-by: Michael Straube <straube.linux@...il.com>

Thanks,
Michael