linux-kernel - Re: [PATCH] lib/string_helpers: add linux/string.h for strlen()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211005233339.luuyt2spalfirqzt@ldmartin-desk2>
Date:   Tue, 5 Oct 2021 16:33:39 -0700
From:   Lucas De Marchi <lucas.demarchi@...el.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH] lib/string_helpers: add linux/string.h for strlen()

On Tue, Oct 05, 2021 at 04:21:21PM -0700, Andrew Morton wrote:
>On Tue,  5 Oct 2021 14:26:34 -0700 Lucas De Marchi <lucas.demarchi@...el.com> wrote:
>
>> linux/string_helpers.h uses strlen(), so include the correpondent
>> header. Otherwise we get a compilation error if it's not also included
>> by whoever included the helper.
>
>Is such a compilation error demonstrable in the current mainline kernel?

No, not with the current mainline. I was just starting to implement some
more helpers there and noticed the issue when including this header from
i915. Then I noticed  Andy and Jani already had similar patches to what
I was doing:

https://lore.kernel.org/all/20210215142137.64476-1-andriy.shevchenko@linux.intel.com/
and https://lore.kernel.org/all/20191023131308.9420-1-jani.nikula@intel.com/

So I'm following up on the first thread abovee to figure out what would
be the proper header to implement this. Meanwhile, we can have this
quick harmless fix.

thanks,
Lucas De Marchi