linux-kernel - Re: [PATCH 05/10] riscv: remove Kconfig check for GCC version for ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202110041750.C90595D1@keescook>
Date:   Mon, 4 Oct 2021 17:50:46 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Palmer Dabbelt <palmer@...belt.com>
Cc:     ndesaulniers@...gle.com, akpm@...ux-foundation.org,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        linux@...musvillemoes.dk, nathan@...nel.org, masahiroy@...nel.org,
        joe@...ches.com, arnd@...nel.org,
        Stephen Rothwell <sfr@...b.auug.org.au>, llvm@...ts.linux.dev,
        linux-kernel@...r.kernel.org,
        Paul Walmsley <paul.walmsley@...ive.com>,
        aou@...s.berkeley.edu, linux-riscv@...ts.infradead.org
Subject: Re: [PATCH 05/10] riscv: remove Kconfig check for GCC version for
 ARCH_RV64I

On Mon, Oct 04, 2021 at 05:40:42PM -0700, Palmer Dabbelt wrote:
> On Mon, 13 Sep 2021 09:23:45 PDT (-0700), keescook@...omium.org wrote:
> > On Fri, Sep 10, 2021 at 04:40:42PM -0700, Nick Desaulniers wrote:
> > > The minimum supported version of GCC is now 5.1. The check wasn't
> > > correct as written anyways since GCC_VERSION is 0 when CC=clang.
> > > 
> > > Cc: Paul Walmsley <paul.walmsley@...ive.com>
> > > Cc: Palmer Dabbelt <palmer@...belt.com>
> > > Cc: Albert Ou <aou@...s.berkeley.edu>
> > > Cc: linux-riscv@...ts.infradead.org
> > > Signed-off-by: Nick Desaulniers <ndesaulniers@...gle.com>
> > 
> > Yeah, good catch for Clang too.
> > 
> > Reviewed-by: Kees Cook <keescook@...omium.org>
> 
> Reviewed-by: Palmer Dabbelt <palmerdabbelt@...gle.com>
> Acked-by: Palmer Dabbelt <palmerdabbelt@...gle.com>
> 
> Only this patch ended up in my inbox.  Where you guys planning on keeping
> this whole series together, or did you want me to pick this for the RISC-V
> tree?

Linus already merged this series (see d20758951f8f28c0ee1b2a8a6bb8189858083895)

-- 
Kees Cook