lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 4 Oct 2021 21:13:27 -0400 From: Stephen Boyd <swboyd@...omium.org> To: Prasad Malisetty <pmaliset@...eaurora.org>, agross@...nel.org, bhelgaas@...gle.com, bjorn.andersson@...aro.org, lorenzo.pieralisi@....com, robh+dt@...nel.org, svarbanov@...sol.com Cc: devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org, linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org, dianders@...omium.org, mka@...omium.org, vbadigan@...eaurora.org, sallenki@...eaurora.org, manivannan.sadhasivam@...aro.org, linux-pci@...r.kernel.org Subject: Re: [PATCH v10 4/5] PCI: qcom: Add a flag in match data along with ops Quoting Prasad Malisetty (2021-10-04 12:41:27) > @@ -1488,7 +1528,13 @@ static int qcom_pcie_probe(struct platform_device *pdev) > > pcie->pci = pci; > > - pcie->ops = of_device_get_match_data(dev); > + pcie_cfg = of_device_get_match_data(dev); > + pcie->ops = pcie_cfg->ops; > + if (!pcie->ops) { Sorry I meant check for pcie_cfg being NULL too. of_device_get_match_data() can return NULL if the match doesn't work for some reason. > + dev_err(dev, "Invalid platform data\n"); > + return -EINVAL; > + } > + pcie->pipe_clk_need_muxing = pcie_cfg->pipe_clk_need_muxing; > > pcie->reset = devm_gpiod_get_optional(dev, "perst", GPIOD_OUT_HIGH); > if (IS_ERR(pcie->reset)) {
Powered by blists - more mailing lists