linux-kernel - Re: [PATCH] serial: 8250_dw: Mark acpi match table as maybe unused

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YVxBphzSDG2VmM4I@smile.fi.intel.com>
Date:   Tue, 5 Oct 2021 15:14:30 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Daniel Palmer <daniel@...f.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-serial@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] serial: 8250_dw: Mark acpi match table as maybe unused

On Fri, Oct 01, 2021 at 09:16:24AM +0900, Daniel Palmer wrote:
> On Fri, 1 Oct 2021 at 06:04, Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:
> > > Doesn't this mean the ACPI table ends up in kernels that will never use ACPI?
> >
> > Yes. Is it a problem (*)? If so, you need to use ifdeffery, since __maybe_unused is
> > not for the ID tables.
> 
> Ok, is there a reason it's not for the ID tables? Does it break something?

It will look ugly. Why we define a table that may or may not be used?
Sounds fishy.

On top of that why you should tell linker to waste resources on something
that you may well know beforehand will be thrown away?

> > *) while justifying this you also need to show why it's a problem specific
> > to the ACPI IDs and not a problem for OF ones, which we have tons of in the
> > Linux kernel without any guards (ifdeffery).
> 
> To be honest I don't care about this too much. I just wanted to cut
> down some of the noise when I build my patch backlog so that warnings
> in the stuff I'm trying to mainline are more visible.

Which is good intention and thanks for doing this!

> For what it's worth I think the OF ids are a bit wasteful.

Exactly my point, but fixing one driver of zillions does not solve the issue
in general.

> For some
> drivers where there are tons of broken variations they add a few K of
> unneeded data. But since everyone now has gigabytes of memory I doubt
> they care...

Some actually cares.

> I'm working with 64MB. :)

Then I would imagine that you already using as less kernel configuration as
possible and have as many modules as you want for the hardware that might
appear to be connected to that board, right? Then again one driver with 100+
bytes doesn't affect really your case. Disabling, for example PRINTK, will
win much more for you.

-- 
With Best Regards,
Andy Shevchenko