linux-kernel - Re: [PATCH v4 3/7] dt-bindings: memory: lpddr2: Add revision-id properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <16f2e720-03d3-1643-5577-4039091a1ffc@gmail.com>
Date:   Wed, 6 Oct 2021 19:11:06 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Rob Herring <robh+dt@...nel.org>
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org
Subject: Re: [PATCH v4 3/7] dt-bindings: memory: lpddr2: Add revision-id
 properties

06.10.2021 18:47, Dmitry Osipenko пишет:
> 06.10.2021 13:59, Krzysztof Kozlowski пишет:
>> On 06/10/2021 01:00, Dmitry Osipenko wrote:
>>> Add optional revision-id standard LPDDR2 properties which will help to
>>> identify memory chip.
>>>
>>> Signed-off-by: Dmitry Osipenko <digetx@...il.com>
>>> ---
>>>  .../memory-controllers/ddr/jedec,lpddr2.yaml         | 12 ++++++++++++
>>>  1 file changed, 12 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr2.yaml b/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr2.yaml
>>> index d99ccad54938..01efb43c3425 100644
>>> --- a/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr2.yaml
>>> +++ b/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr2.yaml
>>> @@ -24,6 +24,16 @@ properties:
>>>            - enum:
>>>                - jedec,lpddr2-nvm
>>>  
>>> +  revision-id1:
>>> +    maximum: 255
>>> +    description: |
>>> +      Revision 1 value of SDRAM chip. Obtained from device datasheet.
>>> +
>>
>> Also type/ref for uint32 needed.
> 
> Also unnecessary :) It's uint32 by default, inferred from the 'maximum'.
> 

Please grep for 'maximum: ' to see that other bindings don't specify the
type.