linux-kernel - Re: [PATCH] asm-generic: correct reference to GENERIC_LIB_DEVMEM_IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mhng-f5938c9b-7fc1-4b0c-9449-7dd1431f5446@palmerdabbelt-glaptop>
Date:   Wed, 06 Oct 2021 09:52:50 -0700 (PDT)
From:   Palmer Dabbelt <palmerdabbelt@...gle.com>
To:     Arnd Bergmann <arnd@...db.de>
CC:     lukas.bulwahn@...il.com, Arnd Bergmann <arnd@...db.de>,
        mcgrof@...nel.org, linux-arch@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject:     Re: [PATCH] asm-generic: correct reference to GENERIC_LIB_DEVMEM_IS_ALLOWED

On Wed, 06 Oct 2021 08:17:38 PDT (-0700), Arnd Bergmann wrote:
> On Wed, Oct 6, 2021 at 5:00 PM Lukas Bulwahn <lukas.bulwahn@...il.com> wrote:
>>
>> Commit 527701eda5f1 ("lib: Add a generic version of devmem_is_allowed()")
>> introduces the config symbol GENERIC_LIB_DEVMEM_IS_ALLOWED, but then
>> falsely refers to CONFIG_GENERIC_DEVMEM_IS_ALLOWED (note the missing LIB
>> in the reference) in ./include/asm-generic/io.h.
>>
>> Luckily, ./scripts/checkkconfigsymbols.py warns on non-existing configs:
>>
>> GENERIC_DEVMEM_IS_ALLOWED
>> Referencing files: include/asm-generic/io.h
>>
>> Correct the name of the config to the intended one.
>>
>> Fixes: 527701eda5f1 ("lib: Add a generic version of devmem_is_allowed()")
>> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>
>
> Acked-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Palmer Dabbelt <palmerdabbelt@...gle.com>
Acked-by: Palmer Dabbelt <palmerdabbelt@...gle.com>

Thanks.  I'm going to assume this is going in through some other tree, 
but IIUC I sent the buggy patch up so LMK if you're expecting it to go 
through mine.