linux-kernel - Re: [PATCH v8 07/11] x86/tdx: Add HLT support for TDX guest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bec1c79c-3c45-91ad-a46e-6c79918f4eca@linux.intel.com>
Date:   Thu, 7 Oct 2021 12:25:57 -0700
From:   "Kuppuswamy, Sathyanarayanan" 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>
To:     Josh Poimboeuf <jpoimboe@...hat.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        x86@...nel.org, Paolo Bonzini <pbonzini@...hat.com>,
        David Hildenbrand <david@...hat.com>,
        Andrea Arcangeli <aarcange@...hat.com>,
        Juergen Gross <jgross@...e.com>, Deep Shah <sdeep@...are.com>,
        VMware Inc <pv-drivers@...are.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>, Peter H Anvin <hpa@...or.com>,
        Dave Hansen <dave.hansen@...el.com>,
        Tony Luck <tony.luck@...el.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Kirill Shutemov <kirill.shutemov@...ux.intel.com>,
        Sean Christopherson <seanjc@...gle.com>,
        Kuppuswamy Sathyanarayanan <knsathya@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 07/11] x86/tdx: Add HLT support for TDX guest



On 10/6/21 12:17 PM, Josh Poimboeuf wrote:
> I'm having trouble following this last comment, does it mean there's no
> way to return the error back to the #VE handler when this is called in
> #VE context?  Seems like that would be any easy problem to solve by
> shuffling the functions a bit.

Currently tdx_*halt() calls are used in both pv_ops and
tdx_handle_virtualization_exception(). If it is just
tdx_handle_virtualization_exception() then we can just return the error
and let exc_virtualization_exception() handle error using ve_raise_fault().

But in this case, since pv_ops is also involved, instead of defining
two different halt handler functions for pv_ops and
exc_virtualization_exception( we just use WARN_ON to report
the error.


-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer