linux-kernel - Re: [PATCH -next] opp: Fix return in _opp_add_static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211008080446.jppjpwjliwdotk3h@vireshk-i7>
Date:   Fri, 8 Oct 2021 13:34:46 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     vireshk@...nel.org, nm@...com, sboyd@...nel.org, d-gerlach@...com,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] opp: Fix return in _opp_add_static_v2()

On 08-10-21, 15:46, YueHaibing wrote:
> Fix sparse warning:
> drivers/opp/of.c:924 _opp_add_static_v2() warn: passing zero to 'ERR_PTR'
> 
> For duplicate OPPs 'ret' be set to zero.
> 
> Fixes: deac8703da5f ("PM / OPP: _of_add_opp_table_v2(): increment count only if OPP is added")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/opp/of.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/opp/of.c b/drivers/opp/of.c
> index 2a97c6535c4c..c32ae7497392 100644
> --- a/drivers/opp/of.c
> +++ b/drivers/opp/of.c
> @@ -921,7 +921,7 @@ static struct dev_pm_opp *_opp_add_static_v2(struct opp_table *opp_table,
>  free_opp:
>  	_opp_free(new_opp);
>  
> -	return ERR_PTR(ret);
> +	return ret ? ERR_PTR(ret) : NULL;
>  }
>  
>  /* Initializes OPP tables based on new bindings */

Applied. Thanks.

-- 
viresh