linux-kernel - Re: [PATCH v3 02/10] cxl/pci: Remove dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211009180409.rf7vqdly4loubthe@intel.com>
Date:   Sat, 9 Oct 2021 11:04:09 -0700
From:   Ben Widawsky <ben.widawsky@...el.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Dan Williams <dan.j.williams@...el.com>, linux-cxl@...r.kernel.org,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org, hch@....de
Subject: Re: [PATCH v3 02/10] cxl/pci: Remove dev_dbg for unknown register
 blocks

On 21-10-09 09:48:10, Joe Perches wrote:
> On Sat, 2021-10-09 at 09:44 -0700, Dan Williams wrote:
> > From: Ben Widawsky <ben.widawsky@...el.com>
> > 
> > While interesting to driver developers, the dev_dbg message doesn't do
> > much except clutter up logs.
> 
> So?  This isn't enabled by default.  How does it 'clutter' logs?
> 

Clutter logs for driver developers working on this subsystem. It's fine to drop
this and just use the next sentence as the explanation as well.

> > This information should be attainable
> > through sysfs, and someday lspci like utilities. This change
> > additionally helps reduce the LOC in a subsequent patch to refactor some
> > of cxl_pci register mapping.
> > 
> > Signed-off-by: Ben Widawsky <ben.widawsky@...el.com>
> > Signed-off-by: Dan Williams <dan.j.williams@...el.com>
> > ---
> >  drivers/cxl/pci.c |    3 ---
> >  1 file changed, 3 deletions(-)
> > 
> > diff --git a/drivers/cxl/pci.c b/drivers/cxl/pci.c
> > index 64180f46c895..ccc7c2573ddc 100644
> > --- a/drivers/cxl/pci.c
> > +++ b/drivers/cxl/pci.c
> > @@ -475,9 +475,6 @@ static int cxl_pci_setup_regs(struct cxl_mem *cxlm)
> >  		cxl_decode_register_block(reg_lo, reg_hi, &bar, &offset,
> >  					  &reg_type);
> >  
> > 
> > -		dev_dbg(dev, "Found register block in bar %u @ 0x%llx of type %u\n",
> > -			bar, offset, reg_type);
> > -
> >  		/* Ignore unknown register block types */
> >  		if (reg_type > CXL_REGLOC_RBI_MEMDEV)
> >  			continue;
> > 
> 
>