linux-kernel - Re: [PATCH] staging: rtl8723bs: hal: remove if condition which is always false

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 10 Oct 2021 16:32:08 +0530
From:   Saurav Girepunje <saurav.girepunje@...il.com>
To:     Fabio Aiuto <fabioaiuto83@...il.com>
Cc:     saurav.girepunje@...mail.com, gregkh@...uxfoundation.org,
        marcocesati@...il.com, dan.carpenter@...cle.com,
        lee.jones@...aro.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: hal: remove if condition which is
 always false



On 10/10/21 4:20 pm, Fabio Aiuto wrote:
> Hello Surav,
> 
> thanks for your patch, see a comment below,
> 
> On Sun, Oct 10, 2021 at 01:02:56PM +0530, Saurav Girepunje wrote:
>> Remove the if condition which is always false. The last update on
>> variable max_rf_path is value 1. It's value is not changing after that.
>> So if condition check for value 2 will be always false only.
>>
>> Signed-off-by: Saurav Girepunje <saurav.girepunje@...il.com>
>> ---
>>   drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.c | 10 ++++------
>>   1 file changed, 4 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.c b/drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.c
>> index 392cc8a398f5..612575ba961a 100644
>> --- a/drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.c
>> +++ b/drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.c
>> @@ -106,12 +106,10 @@ static s16 odm_InbandNoise_Monitor_NSeries(
>>   	pDM_Odm->noise_level.noise[RF_PATH_A] = -110 + reg_c50 + noise_data.sum[RF_PATH_A];
>>   	pDM_Odm->noise_level.noise_all += pDM_Odm->noise_level.noise[RF_PATH_A];
>>
>> -	if (max_rf_path == 2) {
>> -		reg_c58 = (s32)PHY_QueryBBReg(pDM_Odm->Adapter, rOFDM0_XBAGCCore1, bMaskByte0);
>> -		reg_c58 &= ~BIT7;
>> -		pDM_Odm->noise_level.noise[RF_PATH_B] = -110 + reg_c58 + noise_data.sum[RF_PATH_B];
>> -		pDM_Odm->noise_level.noise_all += pDM_Odm->noise_level.noise[RF_PATH_B];
>> -	}
>> +	reg_c58 = (s32)PHY_QueryBBReg(pDM_Odm->Adapter, rOFDM0_XBAGCCore1, bMaskByte0);
>> +	reg_c58 &= ~BIT7;
>> +	pDM_Odm->noise_level.noise[RF_PATH_B] = -110 + reg_c58 + noise_data.sum[RF_PATH_B];
>> +	pDM_Odm->noise_level.noise_all += pDM_Odm->noise_level.noise[RF_PATH_B];
>>   	pDM_Odm->noise_level.noise_all /= max_rf_path;
> 
> If the condition is always false the whole block can be wiped out,
> why did you keep it? Did you change the logic here?
> 
>>
>>   	/*  */
>> --
>> 2.32.0
>>
> 
> thank you,
> 
> fabio
> 

Thanks for review Fabio.
It is changing the logic . I should be careful for this. whole block of 
if statement should also be removed.


Please ignore this patch.

Regards,
Saurav