linux-kernel - Re: [PATCH v1] MIPS: Malta: fix alignment of the devicetree buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 10 Oct 2021 11:58:24 +0200 (CEST)
From:   "Maciej W. Rozycki" <macro@...am.me.uk>
To:     Marc Kleine-Budde <mkl@...gutronix.de>
cc:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Oleksij Rempel <o.rempel@...gutronix.de>,
        Rob Herring <robh@...nel.org>,
        Paul Burton <paulburton@...nel.org>,
        linux-kernel@...r.kernel.org, Ralf Baechle <ralf@...ux-mips.org>,
        linux-mips@...r.kernel.org,
        Pengutronix Kernel Team <kernel@...gutronix.de>
Subject: Re: [PATCH v1] MIPS: Malta: fix alignment of the devicetree buffer

On Thu, 2 Sep 2021, Marc Kleine-Budde wrote:

> > > Starting with following patch MIPS Malta is not able to boot:
> > > | commit 79edff12060fe7772af08607eff50c0e2486c5ba
> > > | Author: Rob Herring <robh@...nel.org>
> > > | scripts/dtc: Update to upstream version v1.6.0-51-g183df9e9c2b9
> 
> If the above patch broke malts, IMHO the fixes tag should be:
> 
> Fixes: 79edff12060f ("scripts/dtc: Update to upstream version v1.6.0-51-g183df9e9c2b9")

 It's not clear either from this patch description or from the commit 
referred what the actual *purpose* of the alignment check is and therefore 
I think it's hard to say which of the two commits needs to be indicated as 
the offender.  Without further data I tend to agree it's 79edff12060f that 
ought to be referred, being the immediate cause of the regression, as 
things obviously worked before, for 5+ years.

> > > The reason is the alignment test added to the fdt_ro_probe_(). To fix
> > > this issue, we need to make sure that fdt_buf is aligned.
> > > 
> > > Since the dtc patch was designed to uncover potential issue, I handle
> > > initial MIPS Malta patch as initial bug.
> > > 
> > > Fixes: e81a8c7dabac ("MIPS: Malta: Setup RAM regions via DT")
> > > Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> > > ---
> > >  arch/mips/mti-malta/malta-dtshim.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > applied to mips-next.
> 
> Please add stable on Cc, as Malta is broken since v5.12
> (79edff12060f == v5.12-rc1~104^2~10^2~3).

 That for sure.

  Maciej