linux-kernel - Re: [PATCH v10 00/11] Add TDX Guest Support (Initial support)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Oct 2021 09:33:23 -0700
From:   Dave Hansen <dave.hansen@...el.com>
To:     Borislav Petkov <bp@...en8.de>,
        "Kuppuswamy, Sathyanarayanan" 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
        Paolo Bonzini <pbonzini@...hat.com>,
        David Hildenbrand <david@...hat.com>,
        Andrea Arcangeli <aarcange@...hat.com>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Juergen Gross <jgross@...e.com>, Deep Shah <sdeep@...are.com>,
        VMware Inc <pv-drivers@...are.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>, Peter H Anvin <hpa@...or.com>,
        Tony Luck <tony.luck@...el.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Kirill Shutemov <kirill.shutemov@...ux.intel.com>,
        Sean Christopherson <seanjc@...gle.com>,
        Kuppuswamy Sathyanarayanan <knsathya@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v10 00/11] Add TDX Guest Support (Initial support)

On 10/11/21 6:03 AM, Borislav Petkov wrote:
> For that you need to write yourself a script which does:
> 
> ARCHES=('i386' 'x86_64')
> 
> 	...
> 
>         for a in "${ARCHES[@]}"
>         do
>                 for cfg in "allnoconfig" "defconfig" "allmodconfig" "allyesconfig"
>                 do
>                         build_kernel $a $cfg
>                 done
>         done
> 
> then find a big fat machine at Intel - I don't think that would post as
> a particularly hard problem :-) - and run it in tmpfs, on your patchset.
> 
> Then you collect build logs and grep them for errors. And for additional
> coverage, when you're done with the above configs, you do randconfigs.
> That's what I do all the time with patchsets and it catches pretty much
> every build error.

FWIW, if you're in search of funky Kconfigs for compiling x86, I've got
a big bundle of them.  In addition, I suggest grepping through any
Kconfig options you add and then toggling *those* options specifically.

The three that come to mind that tend to find bugs the fastest are a
defconfig, plus removing (one at a time):

	CONFIG_CPU_SUP_INTEL
	CONFIG_SMP
	CONFIG_NUMA

In your case, I'd make sure you also flip SECURITY and X86_X2APIC, because:

> +	depends on X86_64 && CPU_SUP_INTEL && PARAVIRT
> +	depends on SECURITY
> +	depends on X86_X2APIC