linux-kernel - Re: [PATCH v10 00/11] Add TDX Guest Support (Initial support)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YWQ2JqkLKoDMYO/W@zn.tnic>
Date:   Mon, 11 Oct 2021 15:03:34 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     "Kuppuswamy, Sathyanarayanan" 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
        Paolo Bonzini <pbonzini@...hat.com>,
        David Hildenbrand <david@...hat.com>,
        Andrea Arcangeli <aarcange@...hat.com>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Juergen Gross <jgross@...e.com>, Deep Shah <sdeep@...are.com>,
        VMware Inc <pv-drivers@...are.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>, Peter H Anvin <hpa@...or.com>,
        Dave Hansen <dave.hansen@...el.com>,
        Tony Luck <tony.luck@...el.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Kirill Shutemov <kirill.shutemov@...ux.intel.com>,
        Sean Christopherson <seanjc@...gle.com>,
        Kuppuswamy Sathyanarayanan <knsathya@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v10 00/11] Add TDX Guest Support (Initial support)

On Sat, Oct 09, 2021 at 01:56:12PM -0700, Kuppuswamy, Sathyanarayanan wrote:
> I thought the above issues warranted a re-submission. I know that it is a mistake
> from my end. But I did not want you to review code changes that might go away
> due to rebase.

That's fine - most of the time I do notice when code is changing and I
even warn submitters about it.

> I have sent v10 within few hours of v9 submission to fix a static inline issue.
> 
> I did not catch it my compilation test because, it happens only with a
> TDX disabled config.

For that you need to write yourself a script which does:

ARCHES=('i386' 'x86_64')

	...

        for a in "${ARCHES[@]}"
        do
                for cfg in "allnoconfig" "defconfig" "allmodconfig" "allyesconfig"
                do
                        build_kernel $a $cfg
                done
        done

then find a big fat machine at Intel - I don't think that would post as
a particularly hard problem :-) - and run it in tmpfs, on your patchset.

Then you collect build logs and grep them for errors. And for additional
coverage, when you're done with the above configs, you do randconfigs.
That's what I do all the time with patchsets and it catches pretty much
every build error.

> Sorry for the trouble again. Please ignore the v9 version. I will try
> not to repeat this in future.

Thanks for that - very much appreciated.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette