linux-kernel - Re: [PATCH] staging: rtl8723bs: hal: remove if condition which is always false

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bdc8c280-534d-5de0-050f-2dc3db2e41d0@gmail.com>
Date:   Mon, 11 Oct 2021 22:41:12 +0530
From:   Saurav Girepunje <saurav.girepunje@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Fabio Aiuto <fabioaiuto83@...il.com>, saurav.girepunje@...mail.com,
        gregkh@...uxfoundation.org, marcocesati@...il.com,
        lee.jones@...aro.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: hal: remove if condition which is
 always false



On 11/10/21 4:11 pm, Dan Carpenter wrote:
> Yep.  And please go through the function and clean up all the references
> to max_rf_path.  Change the "max_rf_path = 0" to 1 and delete the other
> assignment.  Delete the comments about "max_rf_path == 2".
> 
> regards,
> dan carpenter
> 

Yes, Is it good if I send 2 patches one to remove "if condition which is always 
false" and another one to "clean-up all the references to max_rf_path" on a single
patch series. 

Regards,
Saurav