linux-kernel - Re: [PATCH v1] MIPS: Malta: fix alignment of the devicetree buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.2110111004510.12214@angie.orcam.me.uk>
Date:   Mon, 11 Oct 2021 10:09:08 +0200 (CEST)
From:   "Maciej W. Rozycki" <macro@...am.me.uk>
To:     Oleksij Rempel <o.rempel@...gutronix.de>
cc:     Marc Kleine-Budde <mkl@...gutronix.de>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Rob Herring <robh@...nel.org>,
        Paul Burton <paulburton@...nel.org>,
        linux-kernel@...r.kernel.org, Ralf Baechle <ralf@...ux-mips.org>,
        linux-mips@...r.kernel.org,
        Pengutronix Kernel Team <kernel@...gutronix.de>
Subject: Re: [PATCH v1] MIPS: Malta: fix alignment of the devicetree buffer

On Mon, 11 Oct 2021, Oleksij Rempel wrote:

> >  It's not clear either from this patch description or from the commit 
> > referred what the actual *purpose* of the alignment check is and therefore 
> > I think it's hard to say which of the two commits needs to be indicated as 
> > the offender.  Without further data I tend to agree it's 79edff12060f that 
> > ought to be referred, being the immediate cause of the regression, as 
> > things obviously worked before, for 5+ years.
> 
> This patch was already taken. Do I need to do any thing?

 No, unless Thomas chimes in, especially since you've posted v2 already (I 
hope he's sorted the stable part).  Overall we need better change 
descriptions though.

  Maciej