linux-kernel - Re: [PATCH v2 1/3] memory-hotplug.rst: fix two instances of "movablecore" that should be "movable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YWQDcROoBoreeiHZ@kernel.org>
Date:   Mon, 11 Oct 2021 12:27:13 +0300
From:   Mike Rapoport <rppt@...nel.org>
To:     David Hildenbrand <david@...hat.com>
Cc:     linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Jonathan Corbet <corbet@....net>,
        Michal Hocko <mhocko@...e.com>,
        Oscar Salvador <osalvador@...e.de>, linux-doc@...r.kernel.org,
        linux-mm@...ck.org
Subject: Re: [PATCH v2 1/3] memory-hotplug.rst: fix two instances of
 "movablecore" that should be "movable_node"

On Mon, Oct 11, 2021 at 10:20:56AM +0200, David Hildenbrand wrote:
> We really want to refer to the "movable_node" kernel command line
> parameter here.
> 
> Fixes: ac3332c44767 ("memory-hotplug.rst: complete admin-guide overhaul")
> Signed-off-by: David Hildenbrand <david@...hat.com>

Acked-by: Mike Rapoport <rppt@...ux.ibm.com>

> ---
>  Documentation/admin-guide/mm/memory-hotplug.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/admin-guide/mm/memory-hotplug.rst b/Documentation/admin-guide/mm/memory-hotplug.rst
> index 03dfbc925252..27d748cb6ee0 100644
> --- a/Documentation/admin-guide/mm/memory-hotplug.rst
> +++ b/Documentation/admin-guide/mm/memory-hotplug.rst
> @@ -166,7 +166,7 @@ Or alternatively::
>  	% echo 1 > /sys/devices/system/memory/memoryXXX/online
>  
>  The kernel will select the target zone automatically, usually defaulting to
> -``ZONE_NORMAL`` unless ``movablecore=1`` has been specified on the kernel
> +``ZONE_NORMAL`` unless ``movable_node`` has been specified on the kernel
>  command line or if the memory block would intersect the ZONE_MOVABLE already.
>  
>  One can explicitly request to associate an offline memory block with
> @@ -393,7 +393,7 @@ command line parameters are relevant:
>  ======================== =======================================================
>  ``memhp_default_state``	 configure auto-onlining by essentially setting
>                           ``/sys/devices/system/memory/auto_online_blocks``.
> -``movablecore``		 configure automatic zone selection of the kernel. When
> +``movable_node``	 configure automatic zone selection in the kernel. When
>  			 set, the kernel will default to ZONE_MOVABLE, unless
>  			 other zones can be kept contiguous.
>  ======================== =======================================================
> -- 
> 2.31.1
> 

-- 
Sincerely yours,
Mike.